Re: [PATCH 01/16] ehca: integration in Linux kernel build system

Re: [PATCH 01/16] ehca: integration in Linux kernel build system

[Arnd Bergmann]

On Thursday 27 April 2006 14:05, Heiko J Schick wrote:
> Signed-off-by: Heiko J Schick <schickhj@de.ibm.com>
> 

Missing any description whatsoever.

> 
>   Kconfig  |    6 ++++++
>   Makefile |   29 +++++++++++++++++++++++++++++
>   2 files changed, 35 insertions(+)
> 

It would be more practical to put this patch last instead of
first so you don't break the build system with partial applies.

> --- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Kconfig    1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Kconfig 2006-01-04 16:29:05.000000000 +0100
> @@ -0,0 +1,6 @@
> +config INFINIBAND_EHCA
> +       tristate "eHCA support"
> +       depends on IBMEBUS && INFINIBAND
> +       ---help---
> +       This is a low level device driver for the IBM
> +       GX based Host channel adapters (HCAs)
> \ No newline at end of file
> --- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Makefile   1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Makefile        2006-03-06 12:26:36.000000000 +0100
> @@ -0,0 +1,29 @@
> +#  Authors: Heiko J Schick <schickhj@de.ibm.com>
> +#           Christoph Raisch <raisch@de.ibm.com>
> +#
> +#  Copyright (c) 2005 IBM Corporation
> +#
> +#  All rights reserved.
> +#
> +#  This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD.
> +
> +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o
> +
> +hcad_mod-objs = ehca_main.o   \
> +               ehca_hca.o    \
> +               ehca_mcast.o  \
> +               ehca_pd.o     \
> +               ehca_av.o     \
> +               ehca_eq.o     \
> +               ehca_cq.o     \
> +               ehca_qp.o     \
> +               ehca_sqp.o    \
> +               ehca_mrmw.o   \
> +               ehca_reqs.o   \
> +               ehca_irq.o    \
> +               ehca_uverbs.o \
> +               hcp_if.o      \
> +               hcp_phyp.o    \
> +               ipz_pt_fn.o
> +
> +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
> 
Do these need to be on the command line? If you always set them
anyways, you can probably get rid of the #ifdef checking for them.
If you want to keep the code for some reason, it might be better
to have a CONFIG_EHCA_USE_HCALL symbol that is set unconditionally
from Kconfig.

	Arnd <><

[PATCH 01/16] ehca: integration in Linux kernel build system

[Heiko J Schick]

Signed-off-by: Heiko J Schick <schickhj@de.ibm.com>


  Kconfig  |    6 ++++++
  Makefile |   29 +++++++++++++++++++++++++++++
  2 files changed, 35 insertions(+)



--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Kconfig	1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Kconfig	2006-01-04 16:29:05.000000000 +0100
@@ -0,0 +1,6 @@
+config INFINIBAND_EHCA
+       tristate "eHCA support"
+       depends on IBMEBUS && INFINIBAND
+       ---help---
+       This is a low level device driver for the IBM
+       GX based Host channel adapters (HCAs)
\ No newline at end of file
--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Makefile	1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Makefile	2006-03-06 12:26:36.000000000 +0100
@@ -0,0 +1,29 @@
+#  Authors: Heiko J Schick <schickhj@de.ibm.com>
+#           Christoph Raisch <raisch@de.ibm.com>
+#
+#  Copyright (c) 2005 IBM Corporation
+#
+#  All rights reserved.
+#
+#  This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD.
+
+obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o
+
+hcad_mod-objs = ehca_main.o   \
+		ehca_hca.o    \
+		ehca_mcast.o  \
+		ehca_pd.o     \
+		ehca_av.o     \
+		ehca_eq.o     \
+		ehca_cq.o     \
+		ehca_qp.o     \
+		ehca_sqp.o    \
+		ehca_mrmw.o   \
+		ehca_reqs.o   \
+		ehca_irq.o    \
+		ehca_uverbs.o \
+		hcp_if.o      \
+		hcp_phyp.o    \
+		ipz_pt_fn.o
+
+CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL

Re: [PATCH 01/16] ehca: integration in Linux kernel build system

[Jörn Engel]

On Thu, 27 April 2006 14:05:24 +0200, Heiko J Schick wrote:
> +
> +hcad_mod-objs = ehca_main.o   \
> +		ehca_hca.o    \
> +		ehca_mcast.o  \
> +		ehca_pd.o     \
> +		ehca_av.o     \
> +		ehca_eq.o     \
> +		ehca_cq.o     \
> +		ehca_qp.o     \
> +		ehca_sqp.o    \
> +		ehca_mrmw.o   \
> +		ehca_reqs.o   \
> +		ehca_irq.o    \
> +		ehca_uverbs.o \
> +		hcp_if.o      \
> +		hcp_phyp.o    \
> +		ipz_pt_fn.o

If you don't consolidate this into 2-3 lines, Sam might turn you into
a toad.

Jörn

-- 
Audacity augments courage; hesitation, fear.
-- Publilius Syrus 

Re: [PATCH 01/16] ehca: integration in Linux kernel build system

[Heiko J Schick]

On 2006-04-27 13:07:36 +0200, Arnd Bergmann <arnd.bergmann@de.ibm.com> said:

> It would be more practical to put this patch last instead of
> first so you don't break the build system with partial applies.

I agree. I Will change set for the next patchset.