* [PATCH 01/16] ehca: integration in Linux kernel build system
@ 2006-04-27 12:05 Heiko J Schick
2006-04-27 11:07 ` Arnd Bergmann
2006-04-27 12:39 ` Jörn Engel
0 siblings, 2 replies; 4+ messages in thread
From: Heiko J Schick @ 2006-04-27 12:05 UTC (permalink / raw)
To: linux-kernel, openib-general, linuxppc-dev, Marcus Eder,
Christoph Raisch, Hoang-Nam Nguyen, schickhj
Signed-off-by: Heiko J Schick <schickhj@de.ibm.com>
Kconfig | 6 ++++++
Makefile | 29 +++++++++++++++++++++++++++++
2 files changed, 35 insertions(+)
--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Kconfig 1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Kconfig 2006-01-04 16:29:05.000000000 +0100
@@ -0,0 +1,6 @@
+config INFINIBAND_EHCA
+ tristate "eHCA support"
+ depends on IBMEBUS && INFINIBAND
+ ---help---
+ This is a low level device driver for the IBM
+ GX based Host channel adapters (HCAs)
\ No newline at end of file
--- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Makefile 1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100
@@ -0,0 +1,29 @@
+# Authors: Heiko J Schick <schickhj@de.ibm.com>
+# Christoph Raisch <raisch@de.ibm.com>
+#
+# Copyright (c) 2005 IBM Corporation
+#
+# All rights reserved.
+#
+# This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD.
+
+obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o
+
+hcad_mod-objs = ehca_main.o \
+ ehca_hca.o \
+ ehca_mcast.o \
+ ehca_pd.o \
+ ehca_av.o \
+ ehca_eq.o \
+ ehca_cq.o \
+ ehca_qp.o \
+ ehca_sqp.o \
+ ehca_mrmw.o \
+ ehca_reqs.o \
+ ehca_irq.o \
+ ehca_uverbs.o \
+ hcp_if.o \
+ hcp_phyp.o \
+ ipz_pt_fn.o
+
+CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/16] ehca: integration in Linux kernel build system
2006-04-27 12:05 [PATCH 01/16] ehca: integration in Linux kernel build system Heiko J Schick
@ 2006-04-27 11:07 ` Arnd Bergmann
2006-04-27 21:26 ` Heiko J Schick
2006-04-27 12:39 ` Jörn Engel
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2006-04-27 11:07 UTC (permalink / raw)
To: linuxppc-dev
Cc: schickhj, linux-kernel, openib-general, Christoph Raisch,
Hoang-Nam Nguyen, Marcus Eder
On Thursday 27 April 2006 14:05, Heiko J Schick wrote:
> Signed-off-by: Heiko J Schick <schickhj@de.ibm.com>
>
Missing any description whatsoever.
>
> Kconfig | 6 ++++++
> Makefile | 29 +++++++++++++++++++++++++++++
> 2 files changed, 35 insertions(+)
>
It would be more practical to put this patch last instead of
first so you don't break the build system with partial applies.
> --- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Kconfig 1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Kconfig 2006-01-04 16:29:05.000000000 +0100
> @@ -0,0 +1,6 @@
> +config INFINIBAND_EHCA
> + tristate "eHCA support"
> + depends on IBMEBUS && INFINIBAND
> + ---help---
> + This is a low level device driver for the IBM
> + GX based Host channel adapters (HCAs)
> \ No newline at end of file
> --- linux-2.6.17-rc2-orig/drivers/infiniband/hw/ehca/Makefile 1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc2/drivers/infiniband/hw/ehca/Makefile 2006-03-06 12:26:36.000000000 +0100
> @@ -0,0 +1,29 @@
> +# Authors: Heiko J Schick <schickhj@de.ibm.com>
> +# Christoph Raisch <raisch@de.ibm.com>
> +#
> +# Copyright (c) 2005 IBM Corporation
> +#
> +# All rights reserved.
> +#
> +# This source code is distributed under a dual license of GPL v2.0 and OpenIB BSD.
> +
> +obj-$(CONFIG_INFINIBAND_EHCA) += hcad_mod.o
> +
> +hcad_mod-objs = ehca_main.o \
> + ehca_hca.o \
> + ehca_mcast.o \
> + ehca_pd.o \
> + ehca_av.o \
> + ehca_eq.o \
> + ehca_cq.o \
> + ehca_qp.o \
> + ehca_sqp.o \
> + ehca_mrmw.o \
> + ehca_reqs.o \
> + ehca_irq.o \
> + ehca_uverbs.o \
> + hcp_if.o \
> + hcp_phyp.o \
> + ipz_pt_fn.o
> +
> +CFLAGS += -DEHCA_USE_HCALL -DEHCA_USE_HCALL_KERNEL
>
Do these need to be on the command line? If you always set them
anyways, you can probably get rid of the #ifdef checking for them.
If you want to keep the code for some reason, it might be better
to have a CONFIG_EHCA_USE_HCALL symbol that is set unconditionally
from Kconfig.
Arnd <><
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/16] ehca: integration in Linux kernel build system
2006-04-27 12:05 [PATCH 01/16] ehca: integration in Linux kernel build system Heiko J Schick
2006-04-27 11:07 ` Arnd Bergmann
@ 2006-04-27 12:39 ` Jörn Engel
1 sibling, 0 replies; 4+ messages in thread
From: Jörn Engel @ 2006-04-27 12:39 UTC (permalink / raw)
To: Heiko J Schick
Cc: schickhj, linux-kernel, openib-general, linuxppc-dev,
Christoph Raisch, Hoang-Nam Nguyen, Marcus Eder
On Thu, 27 April 2006 14:05:24 +0200, Heiko J Schick wrote:
> +
> +hcad_mod-objs = ehca_main.o \
> + ehca_hca.o \
> + ehca_mcast.o \
> + ehca_pd.o \
> + ehca_av.o \
> + ehca_eq.o \
> + ehca_cq.o \
> + ehca_qp.o \
> + ehca_sqp.o \
> + ehca_mrmw.o \
> + ehca_reqs.o \
> + ehca_irq.o \
> + ehca_uverbs.o \
> + hcp_if.o \
> + hcp_phyp.o \
> + ipz_pt_fn.o
If you don't consolidate this into 2-3 lines, Sam might turn you into
a toad.
Jörn
--
Audacity augments courage; hesitation, fear.
-- Publilius Syrus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-04-27 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-27 12:05 [PATCH 01/16] ehca: integration in Linux kernel build system Heiko J Schick
2006-04-27 11:07 ` Arnd Bergmann
2006-04-27 21:26 ` Heiko J Schick
2006-04-27 12:39 ` Jörn Engel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).