From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: powernv: Fix build error on const discarding
Date: Thu, 17 Aug 2017 19:34:49 +0530 [thread overview]
Message-ID: <e3c580e1-6081-d89e-8324-0e98c2440151@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170816123444.5202-1-clabbe.montjoie@gmail.com>
On Wednesday 16 August 2017 06:04 PM, Corentin Labbe wrote:
> When building a random powerpc kernel I hit this build error:
> CC arch/powerpc/platforms/powernv/opal-imc.o
> arch/powerpc/platforms/powernv/opal-imc.c: In function « disable_nest_pmu_counters »:
> arch/powerpc/platforms/powernv/opal-imc.c:130:13: error : assignment discards « const » qualifier from pointer target type [-Werror=discarded-qualifiers]
> l_cpumask = cpumask_of_node(nid);
> ^
> This patch simply add const to l_cpumask to fix this issue.
Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/powerpc/platforms/powernv/opal-imc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/powernv/opal-imc.c b/arch/powerpc/platforms/powernv/opal-imc.c
> index b903bf5e6006..21f6531fae20 100644
> --- a/arch/powerpc/platforms/powernv/opal-imc.c
> +++ b/arch/powerpc/platforms/powernv/opal-imc.c
> @@ -123,7 +123,7 @@ static int imc_pmu_create(struct device_node *parent, int pmu_index, int domain)
> static void disable_nest_pmu_counters(void)
> {
> int nid, cpu;
> - struct cpumask *l_cpumask;
> + const struct cpumask *l_cpumask;
>
> get_online_cpus();
> for_each_online_node(nid) {
next prev parent reply other threads:[~2017-08-17 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 12:34 [PATCH] powerpc: powernv: Fix build error on const discarding Corentin Labbe
2017-08-17 12:52 ` Michael Ellerman
2017-08-18 12:58 ` Corentin Labbe
2017-08-25 1:26 ` Michael Ellerman
2017-08-17 14:04 ` Madhavan Srinivasan [this message]
2017-08-31 11:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3c580e1-6081-d89e-8324-0e98c2440151@linux.vnet.ibm.com \
--to=maddy@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).