From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB651606A31E for ; Wed, 28 Oct 2026 03:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=XWmRTZzi Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jDtM42Gcvz2xwL; Wed, 28 Oct 2026 14:36:32 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793158592; cv=none; b=EXeR1zRUzeRBsKgx0pSUyFCPpvMmSIKuJ7ozxNAIrCEIHTVqex/Kl0YYsq7jzp01ob4wUkzrJ5nm9etu9pPMRsWgA9lgKLpe6JrtA8zhJOUxCWeehSjD5ObLpqrfV9JHGtW6CUOcZh9XNPsVi38FNPFWroROPtF4t7HmOlCypcGawiTWO2mXayuujpcrDxjTKZizo6pSwnPc5QJ6f0MHWfSVWc9cYMyytin8wNwDz71JqYSHmOmLepx8nyDBLE2l3npPtR9GmYNqZuX+pX0eERguFcWTP2+f8TKJGoTAA2M03Hna8PNhYh8wYRlNVLGPUuMDSOJkm7s7M38Ecth4yQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793158592; c=relaxed/relaxed; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tf3ljWSOQOUokNMaaSThjoVGxb5QPHYcpv4+CBKczFZl/L9An/wktB2NcqhL2/CJHVxjvgMcgzu30P4BPwajovFxxt129pGcNq9IhTElWwpNnNQfqtMwWe4lWyLkmoJOYjo9b5dn9rgCnXwIIU2hx2XCTKxVRcMPtkub5tS57Osf6ll4jZi/Q1nJHB6xWWUoucXqaZ4wAF4iN6UoPchZ9T2dNy2YyHrCVa9fZexDoX8Ret5CZrHf8YXzxX9JC5z1mzod4J8fgrO7T+jhTnZsB44bnjTjpTcVOAf1Ezp/RQB1FQ8LSQHC/dDcQ/+INeVJ3vcsveNvIN96QGC42z/CrA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=XWmRTZzi; dkim-atps=neutral; spf=pass (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=zhongqiu.han@oss.qualcomm.com; receiver=lists.ozlabs.org) smtp.mailfrom=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Jve2qMQH; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=XWmRTZzi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=oss.qualcomm.com (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=zhongqiu.han@oss.qualcomm.com; receiver=lists.ozlabs.org) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jDtM21wMhz2xnv for ; Wed, 28 Oct 2026 14:36:29 +1100 (AEDT) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69S0ixKZ657577 for ; Wed, 28 Oct 2026 03:36:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=Jve2qMQHUqrEssgK LflW6/l7KZ234zJVmm5v4avWWbV1TcUiioz11IU7xNAS3yhP+6JpgpsoOMhZWZvJ IPei/BNfJ7ExWg/tShStITm6QZsRQXDRsGswXFZFnq+o9ga6nmbSa33m3OhRLXWT jNycF1Ub6eUUeiAVgYu5ZaX6svI7KSL3EU6+K53Rnc/d554YMUVQJALzktVCxxiV q+Kz86xf3mp9SK5/sBZk8qiecR2lpX8aT+GhaHVmok95F2t7X+5DAAukw34dJtRr PnVGLMYR/XaeQ9zEg45sqiPgK2kxAakvx9jugL9konNgiu/4GNvqT3B3MXccU96s aGnIQQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjyjpt5bc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Oct 2026 03:36:25 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3acc98e3b3cso447324a91.3 for ; Tue, 27 Oct 2026 20:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793158585; x=1793763385; darn=lists.ozlabs.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=XWmRTZziDQDoSozki9+LiAQqk1Ndi5Z880k07pz2Orhwrw7ou55qSoaMJOLgUrniOQ iTu6pN1qBZa1xStIX1WUZJNGhWB1CMvmCj3G4K4xmZ0uDOTYzVV1Glw+FRFPVtLNR+Ub Bo5Jty5u7dsheAcnx+IWNGbIEosG4wPX2GGT3HH7MY/VfI3LJxzyAgPSQ1azDhYpDny+ G2hnww9m25cN0HP+F/DLZujamGkBY9L9q6rppgtC4Td8OnwTxITDQnXOvxnFdYOuELi8 452XjlPOwlgZLEFo/l9QJSur8iHjFvRlKEcDeLRqegMGyIpnpaRur2KOURsBhpVaFL47 VNNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793158585; x=1793763385; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/wKdshZSDdNYlVlGGww1CWjddpjIdb7CUnZ1PObkTB4=; b=c412vgA/c1TIRwuG6qqFMDgxjVhFNrpbYOL+VkFb65nj1Pz7YEMU/H2dW4nziskRru G3lTZAnN/NXsVZw8eVvcbQsGuIw4Qdif50RhZlaZvePdRLczRG7bY9bPuIODHdMU/wYp 0+UCZnm/z4XBDXlFB6+L7h/P8NLblaj+jyLBdW93KuZYzZHODUjKd4AsdVtgaecQfYpg z/i1othl0wJz5q27BD/KuT4HGEt5BIYwuEaxM4kbzM4GsUOtWXLhJIZApT7IOxH6EIBd LEyvCr2/VDx+ezQBUIuw6yyjuiSQN6H0JrmPrSrMiJydyjhiw9LaErAc4PlI2ml+hq9g i6zg== X-Forwarded-Encrypted: i=1; AKwUvByLeugX9fvNmc2RSHE8lXiOmfen0BzSu9IZmk6oruFl06p095Ut71TJp9yFBsnMRiLEHuYru6R5QsTN/0o=@lists.ozlabs.org X-Gm-Message-State: AFq9FYJZ3tQmTGnA8SRdQ1g1nYyeZDF+A6rWkblqwtuvzVx5QbqBBsMg 93Wkx4y+59b3XF2o85Tb/D+1y0/LbC2o3hVREVmK9LVk+iMX703KxgIzQoiU0QsQzAtCJmPhB5d 8QY63wsXn3p541k9fO/+/OSrRg68LtphO8VgEGiz8JZbF0Wi4OH6OSaYgTjUsHxFcYiuO X-Gm-Gg: AYBFou27PGt9Cmzx4P1xatMVOnutvWdgujkoraq/NW1Y6urQt4gMrpG4XgbqIRhyaFw 3ECVPbkg7iTryVR/itx3Hp1awCL/MrI1xODUwCOaln9IMLc0zJ1ODsCv5fwpk46HztLHwYfMhSN 0bF+6MG1wxwlkvmoHF1O/LGImovn7LF7NeivkBOtYQGgfgApjjErbhIBDuu29Wh7MiS6PXrn0CM hX4tIxQUzRUarth4x0P7R78H0IUwTgvt3cV0THI1wq9aMXUqiedWSVnedd0xsW2vSV2b0z3QVU6 KOujg4RbxV1ogCS+Vd9e3P3idKmPLdsPVI+raEKGV7jqR6lG9YHHbMlrbQWZo1r++gXIuzLVCcz cTWm9Whw+yETGPzOOHNEe2jBiww7oXnLmHrnP0LQxSgvnNvCIQius/uA45fZGWQhU2SACf4LphW Y4hGYdKTNFviWMkH5N2ls7MRjLvWpPcJZz3gYwYmj4P5I= X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818169a91.38.1793158584991; Tue, 27 Oct 2026 20:36:24 -0700 (PDT) X-Received: by 2002:a17:90b:5863:b0:3ac:b3ff:b476 with SMTP id 98e67ed59e1d1-3ae581836a6mr818144a91.38.1793158584441; Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Received: from [10.133.33.27] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae5a48ec90sm899533a91.6.2026.10.27.20.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 20:36:24 -0700 (PDT) Message-ID: Date: Wed, 28 Oct 2026 11:36:16 +0800 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] cpufreq: governor: Initialize kobj_type release callback statically To: Ian Rogers , Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , =?UTF-8?Q?Christian_K=C3=B6nig?= , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Viresh Kumar , zhongqiu.han@oss.qualcomm.com References: <20261027223847.652884-1-irogers@google.com> <20261027223847.652884-5-irogers@google.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20261027223847.652884-5-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfX0YR/vkc5c8pY UNOmOS1zyGgb49MGKYdkr8TowG4mMrbP3gWnUWmNLxiNzJAnjmVMpub32aY3+p4gKv6mmN0nzme Ti6KVr0iTsoiPL6+GtAh3xoyXsp3GoSex87UzXFk8OsQwA4YFGuJ4VVg/9OPLkixSWxrMGSV3XP X2YdiJ6GLBdI9FjsraUBLM502L/lzsHIsjMrhu3ZCvgQ12S8vPQO4Bva3ThmXK2+LyQKEaLCS/+ Vv1NDjUbkjhaxOpZzyvhQX2ofSp6lXmty1ZWYG/xwZCSavrPaAcG1u7WsSKw1io0jJ+GujJvjnL KNAq38j3swVYe5hDVXIM5s4dVrxW5xzFEJkxoLZUaktGv+RgNX39P1QA7AfzcLWLwI8CgKw92tj RUc7SPZ6JyAdq00X0Lxv84K0DnibPAW4a2sL+acun+/auDhK8SYPrABVd1M1INESGhxVnskYuQO wGXvSmXd/m9UHnZ3KKA== X-Proofpoint-ORIG-GUID: C121GT5xXXAUKu77eYUp3jd6MmX5LEu_ X-Proofpoint-GUID: C121GT5xXXAUKu77eYUp3jd6MmX5LEu_ X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI4MDAxNCBTYWx0ZWRfXyp6dpzt7df/6 VoGCt1SEWh6mkB5LzRtbH9Ib6A79CZ0Y11JMrCodOhZYHw7I/rUBUzplz/m5YH1Y3sMSIPrizNF J+IpX9BPJO5lWZFyNBIRfH6e4NwxqoQ= X-Authority-Analysis: v=2.4 cv=JodkP84C c=1 sm=1 tr=0 ts=6ae16db9 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=1XWaLZrsAAAA:8 a=MbyaxBA4Lnn_ULkWIDkA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-28_01,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610280014 X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Ian, Thanks for the update. On 10/28/2026 6:38 AM, Ian Rogers wrote: > Export cpufreq_dbs_data_release() and set .kobj_type.release statically > in the ondemand and conservative governors so their gov_attr_set > kobjects have a valid release callback statically initialized, matching > cpufreq_governor_dbs. Remove the redundant runtime assignment in "matching cpufreq_governor_dbs" is a bit confusing to me (cpufreq_governor_dbs() was removed back in v4.8 by commit e788892ba3cc ("cpufreq: governor: Get rid of governor events")), as it doesn't seem to refer to anything in the tree. Perhaps we could just drop it, e.g.: Export cpufreq_dbs_data_release() and initialize .kobj_type.release statically in the ondemand and conservative governors instead of assigning it at runtime in cpufreq_dbs_governor_init(). The code change itself looks good to me. With the changelog updated (in a respin if the series needs one for other reasons, or when applying): Reviewed-by: Zhongqiu Han > cpufreq_dbs_governor_init(). > > This prepares for annotating struct kobj_type::release with > __must_init. > > Signed-off-by: Ian Rogers > --- > drivers/cpufreq/cpufreq_conservative.c | 5 ++++- > drivers/cpufreq/cpufreq_governor.c | 4 ++-- > drivers/cpufreq/cpufreq_governor.h | 1 + > drivers/cpufreq/cpufreq_ondemand.c | 5 ++++- > 4 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c > index 02bfd46543e9..146a2353b1a2 100644 > --- a/drivers/cpufreq/cpufreq_conservative.c > +++ b/drivers/cpufreq/cpufreq_conservative.c > @@ -318,7 +318,10 @@ static void cs_limits(struct cpufreq_policy *policy) > > static struct dbs_governor cs_governor = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("conservative"), > - .kobj_type = { .default_groups = cs_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = cs_groups, > + }, > .gov_dbs_update = cs_dbs_update, > .alloc = cs_alloc, > .free = cs_free, > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index f3bd3dbe7c41..f8b5aca09b6b 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -419,7 +419,7 @@ static void free_policy_dbs_info(struct policy_dbs_info *policy_dbs, > gov->free(policy_dbs); > } > > -static void cpufreq_dbs_data_release(struct kobject *kobj) > +void cpufreq_dbs_data_release(struct kobject *kobj) > { > struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); > struct dbs_governor *gov = dbs_data->gov; > @@ -427,6 +427,7 @@ static void cpufreq_dbs_data_release(struct kobject *kobj) > gov->exit(dbs_data); > kfree(dbs_data); > } > +EXPORT_SYMBOL_GPL(cpufreq_dbs_data_release); > > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > { > @@ -488,7 +489,6 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) > policy->governor_data = policy_dbs; > > gov->kobj_type.sysfs_ops = &governor_sysfs_ops; > - gov->kobj_type.release = cpufreq_dbs_data_release; > ret = kobject_init_and_add(&dbs_data->attr_set.kobj, &gov->kobj_type, > get_governor_parent_kobj(policy), > "%s", gov->gov.name); > diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h > index 806d8fb4dff1..1026712bb79b 100644 > --- a/drivers/cpufreq/cpufreq_governor.h > +++ b/drivers/cpufreq/cpufreq_governor.h > @@ -150,6 +150,7 @@ static inline struct dbs_governor *dbs_governor_of(struct cpufreq_policy *policy > } > > /* Governor callback routines */ > +void cpufreq_dbs_data_release(struct kobject *kobj); > int cpufreq_dbs_governor_init(struct cpufreq_policy *policy); > void cpufreq_dbs_governor_exit(struct cpufreq_policy *policy); > int cpufreq_dbs_governor_start(struct cpufreq_policy *policy); > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c > index 9942dbb38dae..7386d043c665 100644 > --- a/drivers/cpufreq/cpufreq_ondemand.c > +++ b/drivers/cpufreq/cpufreq_ondemand.c > @@ -374,7 +374,10 @@ static struct od_ops od_ops = { > > static struct dbs_governor od_dbs_gov = { > .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("ondemand"), > - .kobj_type = { .default_groups = od_groups }, > + .kobj_type = { > + .release = cpufreq_dbs_data_release, > + .default_groups = od_groups, > + }, > .gov_dbs_update = od_dbs_update, > .alloc = od_alloc, > .free = od_free, -- Thx and BRs, Zhongqiu Han