Re: [PATCH 0/3] Fix for shellcheck issues with version "0.6"

[kajoljain <kjain@linux.ibm.com>]

On 9/7/23 22:45, Athira Rajeev wrote:
> From: root <root@ltcden13-lp4.aus.stglabs.ibm.com>
> 
> shellcheck was run on perf tool shell scripts s a pre-requisite
> to include a build option for shellcheck discussed here:
> https://www.spinics.net/lists/linux-perf-users/msg25553.html
> 
> And fixes were added for the coding/formatting issues in
> two patchsets:
> https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atrajeev@linux.vnet.ibm.com/
> https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atrajeev@linux.vnet.ibm.com/
> 
> Three additional issues are observed with shellcheck "0.6" and
> this patchset covers those. With this patchset,
> 
> # for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck -S warning $F; done
> # echo $?
> 0
> 

Patchset looks good to me.

Reviewed-by: Kajol Jain <kjain@linux.ibm.com>

Thanks,
Kajol Jain

> Athira Rajeev (3):
>   tests/shell: Fix shellcheck SC1090 to handle the location of sourced
>     files
>   tests/shell: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh
>     tetscase
>   tests/shell: Fix shellcheck warnings for SC2153 in multiple scripts
> 
>  tools/perf/tests/shell/coresight/asm_pure_loop.sh            | 4 ++++
>  tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh     | 4 ++++
>  tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh | 4 ++++
>  tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh  | 4 ++++
>  tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh    | 4 ++++
>  tools/perf/tests/shell/probe_vfs_getname.sh                  | 2 ++
>  tools/perf/tests/shell/record+probe_libc_inet_pton.sh        | 2 ++
>  tools/perf/tests/shell/record+script_probe_vfs_getname.sh    | 2 ++
>  tools/perf/tests/shell/record.sh                             | 1 +
>  tools/perf/tests/shell/stat+csv_output.sh                    | 1 +
>  tools/perf/tests/shell/stat+csv_summary.sh                   | 4 ++--
>  tools/perf/tests/shell/stat+shadow_stat.sh                   | 4 ++--
>  tools/perf/tests/shell/stat+std_output.sh                    | 1 +
>  tools/perf/tests/shell/test_intel_pt.sh                      | 1 +
>  tools/perf/tests/shell/trace+probe_vfs_getname.sh            | 1 +
>  15 files changed, 35 insertions(+), 4 deletions(-)
>