Re: [PATCH v2 0/2] LKDTM powerpc enhancements - Part2

[Sayali Patil <sayalip@linux.ibm.com>]

On 18/05/26 17:28, Michael Ellerman wrote:
> On 18/5/2026 16:56, Sayali Patil wrote:
>> Hi all,
>>
>> This series adds a new LKDTM trigger PPC_RADIX_TLBIEL, to validate
>> machine check handling on radix MMU systems and improves reliability of
>> the PPC_SLB_MULTIHIT test by adding isync instructions after slbmte
>> operations.
>>
>> Please review the patches and provide any feedback or suggestions
>> for improvement.
>>
>> Thanks,
>> Sayali
>>
>> ---
>>
>> v1->v2
>>   - Split the patch series into two parts.
>>   - Updated "lkdtm/powerpc: add PPC_RADIX_TLBIEL test for radix MCE
>>     validation" as per review comments:
>>     Wrapped Hash-MMU specific functions with #ifdef 
>> CONFIG_PPC_64S_HASH_MMU.
>>     Guarded powerpc_crashtypes registration with #ifdef 
>> CONFIG_PPC_BOOK3S_64
>>     Updated comment explaining the MCE trigger condition for radix MMU.
>>
>> v1: https://lore.kernel.org/all/ 
>> cover.1778057685.git.sayalip@linux.ibm.com/
>> ---
>>
>> Sayali Patil (2):
>>    lkdtm/powerpc: add isync after slbmte to enforce SLB update ordering
>>    lkdtm/powerpc: add PPC_RADIX_TLBIEL test for radix MCE validation
>>
>>   drivers/misc/lkdtm/Makefile             |  2 +-
>>   drivers/misc/lkdtm/core.c               |  2 +-
>>   drivers/misc/lkdtm/powerpc.c            | 49 +++++++++++++++++++++++++
>>   tools/testing/selftests/lkdtm/tests.txt |  1 +
>>   4 files changed, 52 insertions(+), 2 deletions(-)
> 
> Both changes look good to me.
> 
> You should send them to Kees, who maintains lkdtm. I've added him to Cc, 
> but that may not be sufficient to get his attention.
> 
> Reviewed-by: Michael Ellerman <mpe@kernel.org>
> 
> cheers
> 
Thanks for the review, Michael!

Hi Kees,

Could you please review these patches and let me know if you have any 
comments?

Thanks,
Sayali