From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Frank Rowand <frowand.list@gmail.com>,
Helge Deller <deller@gmx.de>,
dri-devel <dri-devel@lists.freedesktop.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] of: Create platform devices for OF framebuffers
Date: Wed, 13 Apr 2022 20:02:25 +0200 [thread overview]
Message-ID: <e76a4599-8644-15f6-5d06-288caaa687c9@redhat.com> (raw)
In-Reply-To: <b31df06c-6cce-37dd-5ec1-661fdc8151da@suse.de>
On 4/13/22 19:58, Thomas Zimmermann wrote:
> Hi
[snip]
>>>
>>> /* Populate everything else. */
>>> of_platform_default_populate(NULL, NULL, NULL);
>>
>> I'm pretty sure it's just this call that's the problem for PPC though
>> none of the above existed when adding this caused a regression. Can we
>> remove the ifdef and just make this call conditional on
>> !IS_ENABLED(CONFIG_PPC).
>
> Together with the changes in of_platform_populate_framebuffers(), the
> code is more or less an "if-else" depending on PPC. I'll drop
> of_platform_populate_framebuffers() from the patch and make a separate
> implementation of of_platform_default_populate_init for PPC. Seems like
> the easiest solution to me.
>
That sounds reasonable to me as well. Feel free to retain my R-B tag
when posting v2.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-13 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:24 [PATCH 0/2] of: Register platform device for each framebuffer Thomas Zimmermann
2022-04-13 9:24 ` [PATCH 1/2] of: Create platform devices for OF framebuffers Thomas Zimmermann
2022-04-13 10:45 ` Javier Martinez Canillas
2022-04-13 10:49 ` Thomas Zimmermann
2022-04-13 12:51 ` Rob Herring
2022-04-13 17:58 ` Thomas Zimmermann
2022-04-13 18:02 ` Javier Martinez Canillas [this message]
2022-04-13 18:46 ` Rob Herring
2022-04-13 18:53 ` Rob Herring
2022-04-18 18:09 ` Thomas Zimmermann
2022-04-13 9:24 ` [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device Thomas Zimmermann
2022-04-13 10:50 ` Javier Martinez Canillas
2022-04-13 16:05 ` Daniel Vetter
2022-04-13 18:09 ` Thomas Zimmermann
2022-04-19 7:22 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e76a4599-8644-15f6-5d06-288caaa687c9@redhat.com \
--to=javierm@redhat.com \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).