From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Christoph Hellwig" <hch@lst.de>,
"Andrew Morton" <akpm@linux-foundation.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Matt Turner" <mattst88@gmail.com>,
"Magnus Lindholm" <linmag7@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"Andreas Larsson" <andreas@gaisler.com>,
"Richard Weinberger" <richard@nod.at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Dan Williams" <dan.j.williams@intel.com>,
"Chris Mason" <clm@fb.com>, "David Sterba" <dsterba@suse.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Song Liu" <song@kernel.org>,
"Yu Kuai" <yukuai@fnnas.com>, "Li Nan" <linan122@huawei.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-um@lists.infradead.org, linux-crypto@vger.kernel.org,
linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org,
linux-raid@vger.kernel.org
Subject: Re: [PATCH 03/28] arm64/xor: fix conflicting attributes for xor_block_template
Date: Fri, 27 Mar 2026 09:25:22 +0100 [thread overview]
Message-ID: <e7979928-b33a-4132-b08b-d95b91b14295@app.fastmail.com> (raw)
In-Reply-To: <20260327061704.3707577-4-hch@lst.de>
On Fri, 27 Mar 2026, at 07:16, Christoph Hellwig wrote:
> Commit 2c54b423cf85 ("arm64/xor: use EOR3 instructions when available")
> changes the definition to __ro_after_init instead of const, but failed to
> update the external declaration in xor.h. This was not found because
> xor-neon.c doesn't include <asm/xor.h>, and can't easily do that due to
> current architecture of the XOR code.
>
Even if it did, it wouldn't matter - __ro_after_init has no effect on declarations, only on definitions - it only controls the placement of the object in the .data..ro_after_init section (and declarations don't generate any code)
> Fixes: 2c54b423cf85 ("arm64/xor: use EOR3 instructions when available")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/arm64/include/asm/xor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
next prev parent reply other threads:[~2026-03-27 8:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 6:16 cleanup the RAID5 XOR library v4 Christoph Hellwig
2026-03-27 6:16 ` [PATCH 01/28] xor: assert that xor_blocks is not call from interrupt context Christoph Hellwig
2026-03-27 6:16 ` [PATCH 02/28] arm/xor: remove in_interrupt() handling Christoph Hellwig
2026-03-27 6:16 ` [PATCH 03/28] arm64/xor: fix conflicting attributes for xor_block_template Christoph Hellwig
2026-03-27 8:25 ` Ard Biesheuvel [this message]
2026-03-27 6:16 ` [PATCH 04/28] um/xor: cleanup xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 05/28] xor: move to lib/raid/ Christoph Hellwig
2026-03-27 6:16 ` [PATCH 06/28] xor: small cleanups Christoph Hellwig
2026-03-27 6:16 ` [PATCH 07/28] xor: cleanup registration and probing Christoph Hellwig
2026-03-27 6:16 ` [PATCH 08/28] xor: split xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 09/28] xor: remove macro abuse for XOR implementation registrations Christoph Hellwig
2026-03-27 6:16 ` [PATCH 10/28] xor: move generic implementations out of asm-generic/xor.h Christoph Hellwig
2026-03-27 6:16 ` [PATCH 11/28] alpha: move the XOR code to lib/raid/ Christoph Hellwig
2026-03-27 6:16 ` [PATCH 12/28] arm: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 13/28] arm64: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 14/28] loongarch: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 15/28] powerpc: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 16/28] riscv: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 17/28] sparc: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 18/28] s390: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 19/28] x86: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 20/28] xor: avoid indirect calls for arm64-optimized ops Christoph Hellwig
2026-03-27 6:16 ` [PATCH 21/28] xor: make xor.ko self-contained in lib/raid/ Christoph Hellwig
2026-03-27 6:16 ` [PATCH 22/28] xor: add a better public API Christoph Hellwig
2026-04-10 3:03 ` Dan Williams
2026-03-27 6:16 ` [PATCH 23/28] " Christoph Hellwig
2026-03-27 17:51 ` Andrew Morton
2026-03-27 6:16 ` [PATCH 24/28] async_xor: use xor_gen Christoph Hellwig
2026-04-10 3:19 ` Dan Williams
2026-03-27 6:16 ` [PATCH 25/28] btrfs: " Christoph Hellwig
2026-03-27 6:16 ` [PATCH 26/28] xor: pass the entire operation to the low-level ops Christoph Hellwig
2026-03-27 6:16 ` [PATCH 27/28] xor: use static_call for xor_gen Christoph Hellwig
2026-03-27 6:17 ` [PATCH 28/28] xor: add a kunit test case Christoph Hellwig
2026-03-27 10:37 ` cleanup the RAID5 XOR library v4 Ard Biesheuvel
2026-03-27 17:49 ` Andrew Morton
2026-03-29 21:31 ` Eric Biggers
2026-03-29 22:51 ` Andrew Morton
2026-03-30 4:07 ` Eric Biggers
2026-03-30 5:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7979928-b33a-4132-b08b-d95b91b14295@app.fastmail.com \
--to=ardb@kernel.org \
--cc=Jason@zx2c4.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=andreas@gaisler.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chleroy@kernel.org \
--cc=clm@fb.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dsterba@suse.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@xen0n.name \
--cc=linan122@huawei.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=maddy@linux.ibm.com \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=richard.henderson@linaro.org \
--cc=richard@nod.at \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tytso@mit.edu \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox