Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

[Sourabh Jain <sourabhjain@linux.ibm.com>]

Hello Baoquan,


On 01/02/25 09:52, Baoquan he wrote:
> On 01/31/25 at 05:08pm, Sourabh Jain wrote:
>> Although the crashkernel area is reserved, on architectures like
>> PowerPC, it is possible for the crashkernel reserved area to contain
>> components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments
>> over these components, PowerPC has its own set of APIs to locate holes
>> in the crashkernel reserved area.
>>
>> Add an arch hook in the generic locate mem hole APIs so that
>> architectures can handle such special regions in the crashkernel area
>> while locating memory holes for kexec segments using generic APIs.
>> With this, a lot of redundant arch-specific code can be removed, as it
>> performs the exact same job as the generic APIs.
>>
>> To keep the generic and arch-specific changes separate, the changes
>> related to moving PowerPC to use the generic APIs and the removal of
>> PowerPC-specific APIs for memory hole allocation are done in a
>> subsequent patch titled "powerpc/crash: Use generic APIs to locate
>> memory hole for kdump.
>>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Baoquan he <bhe@redhat.com>
>> Cc: Hari Bathini <hbathini@linux.ibm.com>
>> Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
>> Cc: Mahesh Salgaonkar <mahesh@linux.ibm.com>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: kexec@lists.infradead.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>> ---
>>   include/linux/kexec.h |  9 +++++++++
>>   kernel/kexec_file.c   | 12 ++++++++++++
>>   2 files changed, 21 insertions(+)
> LGTM,
>
> Acked-by: Baoquan He <bhe@redhat.com>

Thanks for the Ack!

- Sourabh Jain