From: Kumar Gala <kumar.gala@freescale.com>
To: "Jason McMullan" <jason.mcmullan@gmail.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: RFC: cpm2_devices.c
Date: Wed, 15 Jun 2005 10:06:05 -0500 [thread overview]
Message-ID: <e7e59bf0180e5958169a0f7fc0196098@freescale.com> (raw)
In-Reply-To: <1118845450.7564.111.camel@jmcmullan.timesys>
On Jun 15, 2005, at 9:24 AM, Jason McMullan wrote:
> My personal opinions:
>
> * Use macro-offsets into a cpm2_map_t struct
Not going to happen. Sorry.
> * Put fcc_c regs back in
Can you explain this. I'm not 100% sure what regs you are referring to.
> * dpram[PROFF_*] should be in the resources list
The patch I posted seems to do that. I'm guessing these comments may
be against Allen's initial patch.
> * cpm2_* is a better name than MPC82xx_* or MPC85xx_*
> * Keep CPM2_DMA, etc, as these *should* be showing up in
> /proc/iomem, since, IIRC, the platform layer does
> reserve them upon registration. (And I *do* have a DMA
> layer then uses CPM2_DMA as a driver-ish thing)
I'll agree on DMA, do you see value in CPM, SI1 and SI2 being here?
And if so for what?
- kumar
next prev parent reply other threads:[~2005-06-15 15:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 18:18 RFC: cpm2_devices.c Allen Curtis
2005-06-15 3:35 ` Kumar Gala
2005-06-15 3:57 ` Allen Curtis
2005-06-15 4:13 ` Kumar Gala
2005-06-15 4:41 ` Allen Curtis
2005-06-15 14:24 ` Jason McMullan
2005-06-15 15:06 ` Kumar Gala [this message]
2005-06-15 17:48 ` Allen Curtis
2005-06-15 18:05 ` Vitaly Bordug
2005-06-15 14:29 ` Kumar Gala
2005-06-15 14:30 ` Kumar Gala
2005-06-16 15:12 ` Dan Malek
2005-06-16 15:33 ` Kumar Gala
2005-06-16 15:42 ` Allen Curtis
2005-06-16 15:53 ` Kumar Gala
2005-06-16 16:39 ` Allen Curtis
2005-06-16 19:33 ` Dan Malek
2005-06-15 7:55 ` Vitaly Bordug
2005-06-15 14:25 ` Kumar Gala
2005-06-15 14:33 ` Jason McMullan
2005-06-15 15:01 ` Kumar Gala
2005-06-15 15:31 ` Vitaly Bordug
2005-06-15 15:41 ` Kumar Gala
2005-06-15 16:07 ` Vitaly Bordug
2005-06-16 6:42 ` Pantelis Antoniou
2005-06-16 9:33 ` Wolfgang Denk
2005-06-16 15:02 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7e59bf0180e5958169a0f7fc0196098@freescale.com \
--to=kumar.gala@freescale.com \
--cc=jason.mcmullan@gmail.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).