Re: [PATCH] powerpc/perf: Fix the threshold event selection for memory events in power10

[Madhavan Srinivasan <maddy@linux.ibm.com>]

On 3/4/21 12:10 PM, Athira Rajeev wrote:
> Memory events (mem-loads and mem-stores) currently use the threshold
> event selection as issue to finish. Power10 supports issue to complete
> as part of thresholding which is more appropriate for mem-loads and
> mem-stores. Hence fix the event code for memory events to use issue
> to complete.

Changes looks fine to me.

Reviewed-by: Madhavan Srinivasan <maddy@linux.ibm.com>

We should also CC stable to include this fix?


> Fixes: a64e697cef23 ("powerpc/perf: power10 Performance Monitoring support")
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
> ---
>   arch/powerpc/perf/power10-events-list.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/perf/power10-events-list.h b/arch/powerpc/perf/power10-events-list.h
> index e45dafe818ed..93be7197d250 100644
> --- a/arch/powerpc/perf/power10-events-list.h
> +++ b/arch/powerpc/perf/power10-events-list.h
> @@ -75,5 +75,5 @@
>    *     thresh end (TE)
>    */
>   
> -EVENT(MEM_LOADS,				0x34340401e0);
> -EVENT(MEM_STORES,				0x343c0401e0);
> +EVENT(MEM_LOADS,				0x35340401e0);
> +EVENT(MEM_STORES,				0x353c0401e0);