From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.170]) by ozlabs.org (Postfix) with ESMTP id 4AF63DDEE8 for ; Tue, 9 Dec 2008 11:31:14 +1100 (EST) Received: by wf-out-1314.google.com with SMTP id 24so1779167wfg.15 for ; Mon, 08 Dec 2008 16:31:13 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2008 17:31:13 -0700 From: "Dan Williams" Sender: dan.j.williams@gmail.com To: "Yuri Tikhonov" Subject: Re: [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses In-Reply-To: <200812090055.26721.yur@emcraft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <200812090055.26721.yur@emcraft.com> Cc: linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, wd@denx.de, dzu@denx.de, yanok@emcraft.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov wrote: > Using src_list argument of async_xor() as a storage for dma addresses > implies sizeof(dma_addr_t) <= sizeof(struct page *) restriction which is > not always true (e.g. ppc440spe). > ppc440spe runs with CONFIG_PHYS_64BIT? If we do this then we need to also change md to limit the number of allowed disks based on the kernel stack size. Because with 256 disks a 4K stack can be consumed by one call to async_pq ((256 sources in raid5.c + 256 sources async_pq.c) * 8 bytes per source on 64-bit). Regards, Dan