linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Dan Williams" <dan.j.williams@intel.com>
To: "Yuri Tikhonov" <yur@emcraft.com>
Cc: linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, wd@denx.de,
	dzu@denx.de, yanok@emcraft.com
Subject: Re: [RFC PATCH 00/11][v3] md: support for asynchronous execution of RAID6 operations
Date: Wed, 14 Jan 2009 12:00:26 -0700	[thread overview]
Message-ID: <e9c3a7c20901141100r666007cbv76a869eddf292371@mail.gmail.com> (raw)
In-Reply-To: <200901130342.55633.yur@emcraft.com>

On Mon, Jan 12, 2009 at 5:42 PM, Yuri Tikhonov <yur@emcraft.com> wrote:
>  Hello,
>
>  This is the next attempt on asynchronous RAID-6 support. This patch-set
> has the Dan Williams' comments (Dec, 17) addressed with the following
> exception:
>
> - I still think that using 'enum dma_ctrl_flags' for PQ-specific
> operations is better than introducing another group of flags and
> enhance the device_prep_dma_pq()/device_prep_dma_pqzero_sum() with one
> more parameter. If unchanged 'enum dma_ctrl_flags' will be a criteria
> of acceptance, please let me know - I'll re-implement this exactly as
> Dan suggested.

Ignore that Dan character :-), dma_ctrl_flags is the proper place for
this functionality.

However, I do not believe we need/want ASYNC_TX_ZERO_{P,Q}.  I will
reply to 0002 and 0003 with details.

>
>
>  Fearing to look like a spammer, I post only those patches, which had
> been affected by the changes intended to address Dan's comments. These
> are the following five:
>
> 0002-async_tx-add-support-for-asynchronous-GF-multiplica.patch
> 0003-async_tx-add-support-for-asynchronous-RAID6-recover.patch
> 0004-md-run-RAID-6-stripe-operations-outside-the-lock.patch
> 0008-md-asynchronous-handle_parity_check6.patch
> 0011-ppc440spe-adma-ADMA-driver-for-the-PPC440SP-e-syst.patch
>
>  As regarding the other six patches of asynchronous RAID-6 support
> patchset:
>
> 0001-async_tx-don-t-use-src_list-argument-of-async_xor.patch
> 0005-md-common-schedule_reconstruction-for-raid5-6.patch
> 0006-md-change-handle_stripe_fill6-to-work-in-asynchrono.patch
> 0007-md-rewrite-handle_stripe_dirtying6-in-asynchronous.patch
> 0009-md-change-handle_stripe6-to-work-asynchronously.patch
> 0010-md-remove-unused-functions.patch
>
>  they are the same as in my 09 Dec 2008 post:

Do you have a git tree where you can post this series?  That would
make it easier for me to track/review.

Thanks,
Dan

  reply	other threads:[~2009-01-14 19:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13  0:42 [RFC PATCH 00/11][v3] md: support for asynchronous execution of RAID6 operations Yuri Tikhonov
2009-01-14 19:00 ` Dan Williams [this message]
2009-01-16  9:06   ` Re[2]: " Yuri Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20901141100r666007cbv76a869eddf292371@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=dzu@denx.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=wd@denx.de \
    --cc=yanok@emcraft.com \
    --cc=yur@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).