linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
	Denis Kirjanov <kda@linux-powerpc.org>
Cc: Darren Stevens <darren@stevens-zone.net>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"R.T.Dickinson" <rtd2@xtra.co.nz>,
	mad skateman <madskateman@gmail.com>
Subject: Re: GIT kernel with the PowerPC updates 5.11-1 doesn't boot on a FSL P5040 board and in a virtual e5500 QEMU machine
Date: Tue, 22 Dec 2020 13:15:55 +0100	[thread overview]
Message-ID: <ea93063b-4c8d-7094-b326-2a8568e2fbb4@xenosoft.de> (raw)
In-Reply-To: <8d25f58b-a7bf-4413-b8cc-ed3bd0107263@xenosoft.de>

Hello,

I compiled the latest Git kernel today and unfortunately the boot issue 
still exists.

I was able to reduce the patch for reverting the changes. In this way we 
know the problematic code now.

vdso-v2.patch:

diff -rupN a/arch/powerpc/kernel/vdso32/vgettimeofday.c 
b/arch/powerpc/kernel/vdso32/vgettimeofday.c
--- a/arch/powerpc/kernel/vdso32/vgettimeofday.c    2020-12-19 
00:01:16.829846652 +0100
+++ b/arch/powerpc/kernel/vdso32/vgettimeofday.c    2020-12-19 
00:00:37.817369691 +0100
@@ -10,12 +10,6 @@ int __c_kernel_clock_gettime(clockid_t c
      return __cvdso_clock_gettime32_data(vd, clock, ts);
  }

-int __c_kernel_clock_gettime64(clockid_t clock, struct 
__kernel_timespec *ts,
-                   const struct vdso_data *vd)
-{
-    return __cvdso_clock_gettime_data(vd, clock, ts);
-}
-
  int __c_kernel_gettimeofday(struct __kernel_old_timeval *tv, struct 
timezone *tz,
                  const struct vdso_data *vd)
  {

----

With this patch, the uImage boots without any problems on my FSL P5040 
board and in a virtual e5500 QEMU machine. Please check the problematic 
code.

Thanks,
Christian



On 19 December 2020 at 01:33pm, Christian Zigotzky wrote:
> On 19 December 2020 at 07:49am, Christophe Leroy wrote:
>>
>>
>> Le 18/12/2020 à 23:49, Christian Zigotzky a écrit :
>>> On 18 December 2020 at 10:25pm, Denis Kirjanov wrote:
>>>  >
>>>  >
>>>  > On Friday, December 18, 2020, Christian Zigotzky 
>>> <chzigotzky@xenosoft.de> wrote:
>>>  >
>>>  >     Hello,
>>>  >
>>>  >     I compiled the latest Git kernel with the new PowerPC updates 
>>> 5.11-1 [1] today. Unfortunately this kernel doesn't boot on my FSL 
>>> P5040 board [2] and in a virtual e5500 QEMU machine [3].
>>>  >
>>>  >     I was able to revert the new PowerPC updates 5.11-1 [4] and 
>>> after a new compiling, the kernel boots without any problems on my 
>>> FSL P5040 board.
>>>  >
>>>  >     Please check the new PowerPC updates 5.11-1.
>>>  >
>>>  >
>>>  > Can you bisect the bad commit?
>>>  >
>>> Hello Denis,
>>>
>>> I have bisected [5] and d0e3fc69d00d1f50d22d6b6acfc555ccda80ad1e 
>>> (powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32) [6] is 
>>> the first bad commit.
>>>
>>> I was able to revert this bad commit and after a new compiling, the 
>>> kernel boots without any problems.
>>
>> That's puzzling.
>>
>> Can you describe the symptoms exactly ? What do you mean by "the 
>> kernel doesn't boot" ? Where and how does it stops booting ?
> It stops during the disk initialisation.
>>
>> This commit only adds a new VDSO call, for getting y2038 compliant 
>> time. At the time I implemented it there was no libc using it yet. Is 
>> your libc using it ?
> I tested it with ubuntu MATE 16.04.7 LTS (32-bit userland + 64-bit 
> kernel) and with Debian Sid (MintPPC and Fienix 32-bit userland + 
> 64-bit kernel) on my FSL P5040 board and in a virtual e5500 QEMU 
> machine. How can I figure out if the libc use it?
>>
>> Where can I find all the elements you are using to boot with QEMU ? 
>> Especially the file MintPPC32-X5000.img
> Download: http://www.xenosoft.de/MintPPC32-X5000.tar.gz (md5sum: 
> b31c1c1ca1fcf5d4cdf110c4bce11654) The password for both 'root' and 
> 'mintppc' is 'mintppc'.
>
> QEMU command with KVM on my P5040 board: qemu-system-ppc64 -M ppce500 
> -cpu e5500 -enable-kvm -m 1024 -kernel uImage -drive 
> format=raw,file=MintPPC32-X5000.img,index=0,if=virtio -netdev 
> user,id=mynet0 -device e1000,netdev=mynet0 -append "rw root=/dev/vda" 
> -device virtio-vga -device virtio-mouse-pci -device 
> virtio-keyboard-pci -device pci-ohci,id=newusb -device 
> usb-audio,bus=newusb.0 -smp 4
>
> QEMU command without KVM on macOS Intel: qemu-system-ppc64 -M ppce500 
> -cpu e5500 -m 1024 -kernel uImage -drive 
> format=raw,file=MintPPC32-X5000.img,index=0,if=virtio -netdev 
> user,id=mynet0 -device virtio-net-pci,netdev=mynet0 -append "rw 
> root=/dev/vda" -device virtio-vga -usb -device usb-ehci,id=ehci 
> -device usb-tablet -device virtio-keyboard-pci -smp 4 -vnc :1
>>
>> Can you also share you kernel config
> See attachment.
>>
>> Thanks
>> Christophe
> Thanks
> Christian
>


  reply	other threads:[~2020-12-22 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 17:45 GIT kernel with the PowerPC updates 5.11-1 doesn't boot on a FSL P5040 board and in a virtual e5500 QEMU machine Christian Zigotzky
2020-12-18 21:25 ` Denis Kirjanov
2020-12-18 22:49   ` Christian Zigotzky
2020-12-19  0:38     ` Christian Zigotzky
2020-12-19  6:49     ` Christophe Leroy
2020-12-19 12:33       ` Christian Zigotzky
2020-12-22 12:15         ` Christian Zigotzky [this message]
2020-12-22 13:14         ` Michael Ellerman
2020-12-24 15:01           ` Christian Zigotzky
2021-01-27 16:07 ` FSL P5040: KVM HV doesn't work with the RC5 of kernel 5.11 Christian Zigotzky
2021-02-01  8:29   ` Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea93063b-4c8d-7094-b326-2a8568e2fbb4@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=darren@stevens-zone.net \
    --cc=kda@linux-powerpc.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madskateman@gmail.com \
    --cc=rtd2@xtra.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).