From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>, Will Deacon <will@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Ding Tianhong <dingtianhong@huawei.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Zefan Li <lizefan@huawei.com>, Borislav Petkov <bp@alien8.de>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linuxppc-dev@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup
Date: Mon, 25 Jan 2021 09:19:35 +0100 [thread overview]
Message-ID: <eaa411c5-c3c1-ff87-a671-4059324d0ee1@csgroup.eu> (raw)
In-Reply-To: <20210124114008.GE694255@infradead.org>
Le 24/01/2021 à 12:40, Christoph Hellwig a écrit :
>> diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h
>> index 2ca708ab9b20..597b40405319 100644
>> --- a/arch/arm64/include/asm/vmalloc.h
>> +++ b/arch/arm64/include/asm/vmalloc.h
>> @@ -1,4 +1,12 @@
>> #ifndef _ASM_ARM64_VMALLOC_H
>> #define _ASM_ARM64_VMALLOC_H
>>
>> +#include <asm/page.h>
>> +
>> +#ifdef CONFIG_HAVE_ARCH_HUGE_VMAP
>> +bool arch_vmap_p4d_supported(pgprot_t prot);
>> +bool arch_vmap_pud_supported(pgprot_t prot);
>> +bool arch_vmap_pmd_supported(pgprot_t prot);
>> +#endif
>
> Shouldn't the be inlines or macros? Also it would be useful
> if the architectures would not have to override all functions
> but just those that are it actually implements?
>
> Also lots of > 80 char lines in the patch.
>
Since https://github.com/linuxppc/linux/commit/bdc48fa11e46f867ea4d75fa59ee87a7f48be144
this 80 char limit is not strongly enforced anymore.
Allthough 80 is still the prefered limit, code is often more readable with a slightly longer single
line that with lines splited.
Christophe
next prev parent reply other threads:[~2021-01-25 8:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 8:22 [PATCH v10 00/12] huge vmalloc mappings Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 01/12] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings Nicholas Piggin
2021-01-24 11:31 ` Christoph Hellwig
2021-01-24 8:22 ` [PATCH v10 02/12] mm: apply_to_pte_range warn and fail if a large pte is encountered Nicholas Piggin
2021-01-24 11:32 ` Christoph Hellwig
2021-01-24 8:22 ` [PATCH v10 03/12] mm/vmalloc: rename vmap_*_range vmap_pages_*_range Nicholas Piggin
2021-01-24 11:34 ` Christoph Hellwig
2021-01-24 8:22 ` [PATCH v10 04/12] mm/ioremap: rename ioremap_*_range to vmap_*_range Nicholas Piggin
2021-01-24 11:36 ` Christoph Hellwig
2021-01-24 12:04 ` Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 05/12] mm: HUGE_VMAP arch support cleanup Nicholas Piggin
2021-01-24 11:40 ` Christoph Hellwig
2021-01-24 12:22 ` Nicholas Piggin
2021-01-25 8:19 ` Christophe Leroy [this message]
2021-01-25 8:40 ` Christophe Leroy
2021-01-24 8:22 ` [PATCH v10 06/12] powerpc: inline huge vmap supported functions Nicholas Piggin
2021-01-25 8:42 ` Christophe Leroy
2021-01-25 11:37 ` Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 07/12] arm64: " Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 08/12] x86: " Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 09/12] mm: Move vmap_range from mm/ioremap.c to mm/vmalloc.c Nicholas Piggin
2021-01-24 14:49 ` Christoph Hellwig
2021-01-24 8:22 ` [PATCH v10 10/12] mm/vmalloc: add vmap_range_noflush variant Nicholas Piggin
2021-01-24 14:51 ` Christoph Hellwig
2021-01-24 8:22 ` [PATCH v10 11/12] mm/vmalloc: Hugepage vmalloc mappings Nicholas Piggin
2021-01-24 15:07 ` Christoph Hellwig
2021-01-24 18:06 ` Randy Dunlap
2021-01-24 23:17 ` Nicholas Piggin
2021-01-25 9:14 ` Christophe Leroy
2021-01-25 11:37 ` Nicholas Piggin
2021-01-25 12:13 ` Christophe Leroy
2021-01-25 12:24 ` David Laight
2021-01-26 9:50 ` Nicholas Piggin
2021-01-24 8:22 ` [PATCH v10 12/12] powerpc/64s/radix: Enable huge " Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa411c5-c3c1-ff87-a671-4059324d0ee1@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dingtianhong@huawei.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).