From: Geoff Levand <geoff@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@kernel.org>
Cc: llvm@lists.linux.dev, Kevin Hao <haokexin@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Justin Stitt <justinstitt@google.com>,
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
linuxppc-dev@lists.ozlabs.org, Bill Wendling <morbo@google.com>
Subject: Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage
Date: Thu, 21 Mar 2024 18:32:25 +0900 [thread overview]
Message-ID: <ec1b6bdf-1676-48fb-99f0-a8cc2a99dd17@infradead.org> (raw)
In-Reply-To: <CAMuHMdW41e+DSBKBgugTkjoLy6bXfji-KWmB_d9EstEv01eC6w@mail.gmail.com>
Hi Geert,
On 3/21/24 17:32, Geert Uytterhoeven wrote:
>> static int ps3_probe_thread(void *data)
>> {
>> - struct ps3_notification_device dev;
>> + static struct ps3_notification_device dev;
>> int res;
>> unsigned int irq;
>> u64 lpar;
>
> Making it static increases kernel size for everyone. So I'd rather
> allocate it dynamically. The thread already allocates a buffer, which
> can be replaced at no cost by allocating a structure containing both
> the ps3_notification_device and the buffer.
This seems like a much better solution.
-Geoff
next prev parent reply other threads:[~2024-03-21 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 18:03 [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage Arnd Bergmann
2024-03-21 0:03 ` Geoff Levand
2024-03-21 8:32 ` Geert Uytterhoeven
2024-03-21 9:32 ` Geoff Levand [this message]
2024-03-22 8:34 ` Geoff Levand
2024-03-22 20:24 ` Arnd Bergmann
2024-03-24 1:19 ` Geoff Levand
2024-03-24 1:23 ` [PATCH] powerpc: Fix PS3 allmodconfig warning Geoff Levand
2024-04-01 7:08 ` [PATCH v2] " Geoff Levand
2024-04-22 8:16 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1b6bdf-1676-48fb-99f0-a8cc2a99dd17@infradead.org \
--to=geoff@infradead.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=aneesh.kumar@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=geert@linux-m68k.org \
--cc=haokexin@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).