From: "Steve Fox" <drfickle@us.ibm.com>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix irq radix tree remapping typo
Date: Thu, 17 Aug 2006 18:01:25 +0000 (UTC) [thread overview]
Message-ID: <ec2atk$f9m$1@sea.gmane.org> (raw)
In-Reply-To: 1155779967.11312.143.camel@localhost.localdomain
On Thu, 17 Aug 2006 03:59:27 +0200, Benjamin Herrenschmidt wrote:
> The code for using the radix tree for reverse mapping of interrupts has
> a typo that causes it to create incorrect mappings if the software and
> hardware numbers happen to be different. This would, among others, cause
> the IDE interrupt to fail on js20's. This fixes it.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Please apply to 2.6.18
>
> Index: linux-work/arch/powerpc/kernel/irq.c
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/irq.c 2006-08-17 09:26:19.000000000 +1000
> +++ linux-work/arch/powerpc/kernel/irq.c 2006-08-17 11:27:30.000000000 +1000
> @@ -693,7 +693,7 @@ unsigned int irq_radix_revmap(struct irq
> /* If not there, try to insert it */
> virq = irq_find_mapping(host, hwirq);
> if (virq != NO_IRQ)
> - radix_tree_insert(tree, virq, &irq_map[virq]);
> + radix_tree_insert(tree, hwirq, &irq_map[virq]);
> bail:
> spin_unlock_irqrestore(&irq_big_lock, flags);
> return virq;
This patch has fixed booting on the machine I originally reported the
issue with. Thanks much.
Acked-by: Steve Fox <drfickle@us.ibm.com>
--
Steve Fox
IBM Linux Technology Center
prev parent reply other threads:[~2006-08-17 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 1:59 [PATCH] Fix irq radix tree remapping typo Benjamin Herrenschmidt
2006-08-17 18:01 ` Steve Fox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ec2atk$f9m$1@sea.gmane.org' \
--to=drfickle@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).