From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ssx@qnx.com" <ssx@qnx.com>
Subject: Re: Is PPC 44x PIKA Warp board still relevant?
Date: Mon, 26 Sep 2022 06:34:17 +0000 [thread overview]
Message-ID: <ed43b0d6-d6d4-73d2-b4ab-637f6d2e310e@csgroup.eu> (raw)
In-Reply-To: <Yy/hv2fOLzdWOuvT@google.com>
Hi Dmitry
Le 25/09/2022 à 07:06, Dmitry Torokhov a écrit :
> Hi Michael, Nick,
>
> I was wondering if PIKA Warp board still relevant. The reason for my
> question is that I am interested in dropping legacy gpio APIs,
> especially OF-specific ones, in favor of newer gpiod APIs, and
> arch/powerpc/platforms/44x/warp.c is one of few users of it.
As far as I can see, that board is still being sold, see
https://www.voipon.co.uk/pika-warp-asterisk-appliance-p-932.html
>
> The code in question is supposed to turn off green led and flash red led
> in case of overheating, and is doing so by directly accessing GPIOs
> owned by led-gpio driver without requesting/allocating them. This is not
> really supported with gpiod API, and is not a good practice in general.
As far as I can see, it was ported to led-gpio by
ba703e1a7a0b powerpc/4xx: Have Warp take advantage of GPIO LEDs
default-state = keep
805e324b7fbd powerpc: Update Warp to use leds-gpio driver
> Before I spend much time trying to implement a replacement without
> access to the hardware, I wonder if this board is in use at all, and if
> it is how important is the feature of flashing red led on critical
> temperature shutdown?
>
Don't know who can tell it ?
Maybe let's perform a more standard implementation is see if anybody
screams ?
Christophe
next prev parent reply other threads:[~2022-09-26 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 5:06 Is PPC 44x PIKA Warp board still relevant? Dmitry Torokhov
2022-09-26 6:34 ` Christophe Leroy [this message]
2022-09-26 10:41 ` Michael Ellerman
2022-09-27 6:01 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed43b0d6-d6d4-73d2-b4ab-637f6d2e310e@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ssx@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).