Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

["Timur Tabi" <timur@freescale.com>]

On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
> provide soft power-off function, but also exports two GPIOs (wired to
> the LEDs and also available from the external headers).
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Kumar, I think you merged this patch incorrectly ...

> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> index 7fc5414..4bdbaf4 100644
> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> @@ -91,6 +91,14 @@
>                                interrupts = <18 0x8>;
>                                interrupt-parent = <&ipic>;
>                        };
> +
> +                       mcu_pio: mcu@a {
> +                               #gpio-cells = <2>;
> +                               compatible = "fsl,mc9s08qg8-mpc8349emitx",
> +                                            "fsl,mcu-mpc8349emitx";
> +                               reg = <0x0a>;
> +                               gpio-controller;
> +                       };

This node is supposed to go under the I2C node, but you put it under
the DMA node.

-- 
Timur Tabi
Linux kernel developer at Freescale