From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.241]) by ozlabs.org (Postfix) with ESMTP id 25267DDE24 for ; Sun, 21 Dec 2008 14:23:08 +1100 (EST) Received: by an-out-0708.google.com with SMTP id d11so508394and.39 for ; Sat, 20 Dec 2008 19:23:06 -0800 (PST) Message-ID: Date: Sat, 20 Dec 2008 21:23:06 -0600 From: "Timur Tabi" Sender: timur.tabi@gmail.com To: "Anton Vorontsov" Subject: Re: [PATCH 6/6] ucc_geth: Remove UGETH_FILTERING dead code In-Reply-To: <20081218182335.GF30682@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20081218182335.GF30682@oksana.dev.rtsoft.ru> Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, Andy Fleming , Li Yang , Jeff Garzik , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov wrote: > The code appears to be dead: nobody call these functions, plus build > breaks when UGETH_FILTERING is enabled: I general, I agree with patches like this, but I'd like to hear from Leo first why this code was written in the first place before I can ack it. -- Timur Tabi Linux kernel developer at Freescale