From: "Timur Tabi" <timur@freescale.com>
To: "Becky Bruce" <beckyb@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Update 8641hpcn dts file to match latest u-boot
Date: Sat, 20 Dec 2008 21:27:31 -0600 [thread overview]
Message-ID: <ed82fe3e0812201927j2cf2786ag320e9ebd3b7c7954@mail.gmail.com> (raw)
In-Reply-To: <1229724312-20406-1-git-send-email-beckyb@kernel.crashing.org>
On Fri, Dec 19, 2008 at 4:05 PM, Becky Bruce <beckyb@kernel.crashing.org> wrote:
> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> @@ -26,7 +26,7 @@
> serial1 = &serial1;
> pci0 = &pci0;
> pci1 = &pci1;
> - rapidio0 = &rapidio0;
> + /* rapidio0 = &rapidio0; */
If you're going to leave commented-out code in the DTS, please add a
comment here to explain why the code is commented-out and not just
deleted.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-12-21 3:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 22:05 [PATCH] powerpc: Update 8641hpcn dts file to match latest u-boot Becky Bruce
2008-12-21 3:27 ` Timur Tabi [this message]
2008-12-30 17:24 ` Kumar Gala
2008-12-30 17:27 ` Kumar Gala
2008-12-30 22:27 ` Matt Sealey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed82fe3e0812201927j2cf2786ag320e9ebd3b7c7954@mail.gmail.com \
--to=timur@freescale.com \
--cc=beckyb@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).