From: Timur Tabi <timur@freescale.com>
To: Dushara Jayasinghe <DusharaJ@optiscan.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Aggrwal Poonam-B10812 <Poonam.Aggrwal@freescale.com>
Subject: Re: Newby trying to get Ethernet going on MPC83xx series device.
Date: Thu, 19 Feb 2009 09:17:30 -0600 [thread overview]
Message-ID: <ed82fe3e0902190717p5658fc12k7552a9e178e9302@mail.gmail.com> (raw)
In-Reply-To: <DE0CCFFBFF707949BEABD4537A14ACBA0C04B4054B@mailsvr>
On Thu, Feb 19, 2009 at 12:58 AM, Dushara Jayasinghe
<DusharaJ@optiscan.com> wrote:
> I based my board specific file on mpc834x_itx.c which had
>
> static struct of_device_id __initdata mpc834x_itx_ids[] = {
> { .compatible = "fsl,pq2pro-localbus", },
> { .compatible = "simple-bus", },
> {},
> };
>
> Don't know if this is broken?
Actually, it's your device tree that's broken. The above is the right
way to do it. The other way:
static struct of_device_id mpc834x_ids[] = {
{ .type = "soc", },
{ .compatible = "soc", },
{ .compatible = "simple-bus", },
{},
};
is the old way. You're missing a compatible=simple-bus in your device tree.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-02-19 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 4:26 Newby trying to get Ethernet going on MPC83xx series device Dushara Jayasinghe
2009-02-19 5:21 ` Li Yang-R58472
2009-02-19 6:33 ` Dushara Jayasinghe
2009-02-19 6:41 ` Li Yang-R58472
2009-02-19 6:48 ` Aggrwal Poonam-B10812
2009-02-19 6:58 ` Dushara Jayasinghe
2009-02-19 7:19 ` Li Yang
2009-02-19 7:25 ` Aggrwal Poonam-B10812
2009-02-20 0:36 ` Dushara Jayasinghe
2009-02-20 5:00 ` Michael Bergandi
2009-02-20 7:18 ` Dushara Jayasinghe
2009-02-23 5:28 ` Dushara Jayasinghe
2009-02-23 18:14 ` Michael Bergandi
2009-02-19 15:17 ` Timur Tabi [this message]
2009-02-19 18:38 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed82fe3e0902190717p5658fc12k7552a9e178e9302@mail.gmail.com \
--to=timur@freescale.com \
--cc=DusharaJ@optiscan.com \
--cc=Poonam.Aggrwal@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).