From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.25]) by ozlabs.org (Postfix) with ESMTP id A46ABDDD0B for ; Mon, 6 Apr 2009 05:25:15 +1000 (EST) Received: by qw-out-2122.google.com with SMTP id 9so1245613qwb.15 for ; Sun, 05 Apr 2009 12:25:13 -0700 (PDT) MIME-Version: 1.0 Sender: timur.tabi@gmail.com In-Reply-To: <85829FCA-D181-4992-9889-640B3329D023@kernel.crashing.org> References: <20090404183319.GA22203@oksana.dev.rtsoft.ru> <20090405085243.GA16005@oksana.dev.rtsoft.ru> <85829FCA-D181-4992-9889-640B3329D023@kernel.crashing.org> Date: Sun, 5 Apr 2009 14:18:20 -0500 Message-ID: Subject: Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines From: Timur Tabi To: Kumar Gala Content-Type: text/plain; charset=ISO-8859-1 Cc: Becky Bruce , alsa-devel@alsa-project.org, Mark Brown , linuxppc-dev@ozlabs.org, Liam Girdwood List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Apr 5, 2009 at 9:59 AM, Kumar Gala wrot= e: > No, I think we should just fix drivers. =A0There aren't that many SoC dri= vers > and once they are fixed this will resolve itself. I agree. The only reason I passed NULL when I wrote the drivers was because I was too lazy to figure out what the right dev pointer was. ASoC is kinda screwy in that many fields are not initialized when you think they should be. More than once I passed a pointer to a wrong object without realizing it, even though the code worked. I'll check out these two patches on Monday. --=20 Timur Tabi Linux kernel developer at Freescale