From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Ted Peters <ted.peters@freescale.com>
Subject: Re: [PATCH] powerpc/85xx: Add P2020DS board support
Date: Wed, 15 Apr 2009 10:59:42 -0500 [thread overview]
Message-ID: <ed82fe3e0904150859y3d8cea6dv9f9b88cc4939e9df@mail.gmail.com> (raw)
In-Reply-To: <1239810564-8403-1-git-send-email-galak@kernel.crashing.org>
On Wed, Apr 15, 2009 at 10:49 AM, Kumar Gala <galak@kernel.crashing.org> wr=
ote:
> --- a/arch/powerpc/platforms/fsl_uli1575.c
> +++ b/arch/powerpc/platforms/fsl_uli1575.c
> @@ -57,7 +57,7 @@ static void __devinit early_uli5249(struct pci_dev *dev=
)
> =A0 =A0 =A0 =A0unsigned char temp;
>
> =A0 =A0 =A0 =A0if (!machine_is(mpc86xx_hpcn) && !machine_is(mpc8544_ds) &=
&
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 !machine_is(mpc8572_ds))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 !machine_is(mpc8572_ds) && =
!machine_is(p2020_ds))
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return;
Are we going to need to update this function every time we add a new
board that has an ULI 1575 on it? Can't we define some property in
the device tree to handle this?
--=20
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2009-04-15 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 15:49 [PATCH] powerpc/85xx: Add P2020DS board support Kumar Gala
2009-04-15 15:59 ` Timur Tabi [this message]
2009-04-15 16:17 ` Kumar Gala
2009-04-15 16:50 ` Anton Vorontsov
2009-04-15 17:22 ` Kumar Gala
2009-04-15 17:54 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed82fe3e0904150859y3d8cea6dv9f9b88cc4939e9df@mail.gmail.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ted.peters@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).