From: Jason Wessel <jason.wessel@windriver.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Daniel Thompson <daniel.thompson@linaro.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH] kdb: print real address of pointers instead of hashed addresses
Date: Mon, 1 Oct 2018 14:55:57 -0500 [thread overview]
Message-ID: <ed907623-d636-0d18-95b0-33249c3d88cf@windriver.com> (raw)
In-Reply-To: <e5f8f6e3e5a5595be08127eefae8025ebbb691cc.1538068025.git.christophe.leroy@c-s.fr>
On 09/27/2018 12:17 PM, Christophe Leroy wrote:
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p"),
> all pointers printed with %p are printed with hashed addresses
> instead of real addresses in order to avoid leaking addresses in
> dmesg and syslog. But this applies to kdb too, with is unfortunate:
>
> Entering kdb (current=0x(ptrval), pid 329) due to Keyboard Entry
> kdb> ps
> 15 sleeping system daemon (state M) processes suppressed,
> use 'ps A' to see all.
> Task Addr Pid Parent [*] cpu State Thread Command
> 0x(ptrval) 329 328 1 0 R 0x(ptrval) *sh
>
> 0x(ptrval) 1 0 0 0 S 0x(ptrval) init
> 0x(ptrval) 3 2 0 0 D 0x(ptrval) rcu_gp
> 0x(ptrval) 4 2 0 0 D 0x(ptrval) rcu_par_gp
> 0x(ptrval) 5 2 0 0 D 0x(ptrval) kworker/0:0
> 0x(ptrval) 6 2 0 0 D 0x(ptrval) kworker/0:0H
> 0x(ptrval) 7 2 0 0 D 0x(ptrval) kworker/u2:0
> 0x(ptrval) 8 2 0 0 D 0x(ptrval) mm_percpu_wq
> 0x(ptrval) 10 2 0 0 D 0x(ptrval) rcu_preempt
>
> The whole purpose of kdb is to debug, and for debugging real addresses
> need to be known. In addition, data displayed by kdb doesn't go into
> dmesg.
>
I completely agree. This is added to the merge queue.
Cheers,
Jason.
prev parent reply other threads:[~2018-10-01 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 17:17 [PATCH] kdb: print real address of pointers instead of hashed addresses Christophe Leroy
2018-09-27 17:17 ` Christophe Leroy
2018-10-01 19:55 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed907623-d636-0d18-95b0-33249c3d88cf@windriver.com \
--to=jason.wessel@windriver.com \
--cc=christophe.leroy@c-s.fr \
--cc=daniel.thompson@linaro.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox