From: "Arnd Bergmann" <arnd@arndb.de>
To: "Tom Rix" <trix@redhat.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: remove unneeded if-checks
Date: Sat, 29 Apr 2023 16:24:34 +0200 [thread overview]
Message-ID: <edb707c2-2abb-4260-9c41-c60b5efed2a3@app.fastmail.com> (raw)
In-Reply-To: <20230428221240.2679194-1-trix@redhat.com>
On Sat, Apr 29, 2023, at 00:12, Tom Rix wrote:
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 330 | ;
> | ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 333 | ;
> | ^
>
> These if-checks do not do anything so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
The original intention was to document that there are other
flags that could be handled here, but clearly nobody is adding
code to spufs, so there is no point in keeping that.
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-04-29 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 22:12 [PATCH] powerpc: remove unneeded if-checks Tom Rix
2023-04-29 6:25 ` Christophe Leroy
2023-04-29 14:24 ` Arnd Bergmann [this message]
2023-07-03 5:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb707c2-2abb-4260-9c41-c60b5efed2a3@app.fastmail.com \
--to=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).