* [PATCH] powerpc: remove unneeded if-checks
@ 2023-04-28 22:12 Tom Rix
2023-04-29 6:25 ` Christophe Leroy
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Rix @ 2023-04-28 22:12 UTC (permalink / raw)
To: arnd, mpe, npiggin, christophe.leroy; +Cc: Tom Rix, linuxppc-dev, linux-kernel
For ppc64, gcc with W=1 reports
arch/powerpc/platforms/cell/spu_base.c:330:17: error:
suggest braces around empty body in an 'if' statement [-Werror=empty-body]
330 | ;
| ^
arch/powerpc/platforms/cell/spu_base.c:333:17: error:
suggest braces around empty body in an 'if' statement [-Werror=empty-body]
333 | ;
| ^
These if-checks do not do anything so remove them.
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/powerpc/platforms/cell/spu_base.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index 7bd0b563e163..dea6f0f25897 100644
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data)
if (stat & CLASS1_STORAGE_FAULT_INTR)
__spu_trap_data_map(spu, dar, dsisr);
- if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR)
- ;
-
- if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR)
- ;
-
spu->class_1_dsisr = 0;
spu->class_1_dar = 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: remove unneeded if-checks
2023-04-28 22:12 [PATCH] powerpc: remove unneeded if-checks Tom Rix
@ 2023-04-29 6:25 ` Christophe Leroy
2023-04-29 14:24 ` Arnd Bergmann
2023-07-03 5:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2023-04-29 6:25 UTC (permalink / raw)
To: Tom Rix, arnd@arndb.de, mpe@ellerman.id.au, npiggin@gmail.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Le 29/04/2023 à 00:12, Tom Rix a écrit :
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 330 | ;
> | ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 333 | ;
> | ^
>
> These if-checks do not do anything so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Fixes: 67207b9664a8 ("[PATCH] spufs: The SPU file system, base")
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
> arch/powerpc/platforms/cell/spu_base.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
> index 7bd0b563e163..dea6f0f25897 100644
> --- a/arch/powerpc/platforms/cell/spu_base.c
> +++ b/arch/powerpc/platforms/cell/spu_base.c
> @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data)
> if (stat & CLASS1_STORAGE_FAULT_INTR)
> __spu_trap_data_map(spu, dar, dsisr);
>
> - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR)
> - ;
> -
> - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR)
> - ;
> -
> spu->class_1_dsisr = 0;
> spu->class_1_dar = 0;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: remove unneeded if-checks
2023-04-28 22:12 [PATCH] powerpc: remove unneeded if-checks Tom Rix
2023-04-29 6:25 ` Christophe Leroy
@ 2023-04-29 14:24 ` Arnd Bergmann
2023-07-03 5:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-04-29 14:24 UTC (permalink / raw)
To: Tom Rix, Michael Ellerman, Nicholas Piggin, Christophe Leroy
Cc: linuxppc-dev, linux-kernel
On Sat, Apr 29, 2023, at 00:12, Tom Rix wrote:
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 330 | ;
> | ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 333 | ;
> | ^
>
> These if-checks do not do anything so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
The original intention was to document that there are other
flags that could be handled here, but clearly nobody is adding
code to spufs, so there is no point in keeping that.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: remove unneeded if-checks
2023-04-28 22:12 [PATCH] powerpc: remove unneeded if-checks Tom Rix
2023-04-29 6:25 ` Christophe Leroy
2023-04-29 14:24 ` Arnd Bergmann
@ 2023-07-03 5:26 ` Michael Ellerman
2 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2023-07-03 5:26 UTC (permalink / raw)
To: arnd, npiggin, christophe.leroy, Tom Rix; +Cc: linuxppc-dev, linux-kernel
On Fri, 28 Apr 2023 18:12:40 -0400, Tom Rix wrote:
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 330 | ;
> | ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 333 | ;
> | ^
>
> [...]
Applied to powerpc/next.
[1/1] powerpc: remove unneeded if-checks
https://git.kernel.org/powerpc/c/da5311a4b852eaf2c0feac8b28884a8d8a801dfc
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-03 6:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-28 22:12 [PATCH] powerpc: remove unneeded if-checks Tom Rix
2023-04-29 6:25 ` Christophe Leroy
2023-04-29 14:24 ` Arnd Bergmann
2023-07-03 5:26 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).