From: Balbir Singh <bsingharora@gmail.com>
To: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Cc: kexec@lists.infradead.org,
Stewart Smith <stewart@linux.vnet.ibm.com>,
Baoquan He <bhe@redhat.com>,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Eric Biederman <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument.
Date: Wed, 17 Aug 2016 12:04:49 +1000 [thread overview]
Message-ID: <edca3e4a-1901-eab4-6626-390c835b00c7@gmail.com> (raw)
In-Reply-To: <2089791.XEmIvA1k4K@hactar>
On 17/08/16 04:49, Thiago Jung Bauermann wrote:
> Am Dienstag, 16 August 2016, 16:15:55 schrieb Balbir Singh:
>> On 16/08/16 00:49, Thiago Jung Bauermann wrote:
>>> Am Montag, 15 August 2016, 17:30:49 schrieb Balbir Singh:
>>>> On Thu, Aug 11, 2016 at 08:08:07PM -0300, Thiago Jung Bauermann wrote:
>>>>> Adapt all callers to the new function prototype.
>>>>
>>>> Could you please expand on this?
>>>
>>> Is the following better?
>>>
>>> Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer.
>>
>> Yes and the reason for doing so? Consolidation/clarity of implementation?
>
> Indeed. What about this commit message?
>
> Subject: [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take
> kexec_buf as argument.
>
> This is done to simplify the kexec_add_buffer argument list.
> Adapt all callers to set up a kexec_buf to pass to kexec_add_buffer.
>
> In addition, change the type of kexec_buf.buffer from char * to void *.
> There is no particular reason for it to be a char *, and the change
> allows us to get rid of 3 existing casts to char * in the code.
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
> Acked-by: Dave Young <dyoung@redhat.com>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
>
Looks good
Balbir
next prev parent reply other threads:[~2016-08-17 2:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 23:08 [PATCH v5 00/13] kexec_file_load implementation for PowerPC Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 01/13] kexec_file: Allow arch-specific memory walking for kexec_add_buffer Thiago Jung Bauermann
2016-08-13 6:56 ` Balbir Singh
2016-08-11 23:08 ` [PATCH v5 02/13] kexec_file: Change kexec_add_buffer to take kexec_buf as argument Thiago Jung Bauermann
2016-08-15 7:30 ` Balbir Singh
2016-08-15 14:49 ` Thiago Jung Bauermann
2016-08-16 6:15 ` Balbir Singh
2016-08-16 18:49 ` Thiago Jung Bauermann
2016-08-17 2:04 ` Balbir Singh [this message]
2016-08-11 23:08 ` [PATCH v5 03/13] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 04/13] powerpc: Factor out relocation code from module_64.c to elf_util_64.c Thiago Jung Bauermann
2016-08-15 7:46 ` Balbir Singh
2016-08-15 23:25 ` Thiago Jung Bauermann
2016-08-16 6:52 ` Balbir Singh
2016-08-23 3:01 ` Thiago Jung Bauermann
2016-08-23 3:21 ` Balbir Singh
2016-08-24 0:50 ` Oliver O'Halloran
2016-08-24 0:53 ` Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 05/13] powerpc: Generalize elf64_apply_relocate_add Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 06/13] powerpc: Adapt elf64_apply_relocate_add for kexec_file_load Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 07/13] powerpc: Add functions to read ELF files of any endianness Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 08/13] powerpc: Implement kexec_file_load Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 09/13] powerpc: Add code to work with device trees in kexec_file_load Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 10/13] powerpc: Add support for loading ELF kernels with kexec_file_load Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 11/13] powerpc: Allow userspace to set device tree properties in kexec_file_load Thiago Jung Bauermann
2016-08-12 0:45 ` Samuel Mendoza-Jonas
2016-08-12 0:54 ` Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 12/13] powerpc: Add purgatory for kexec_file_load implementation Thiago Jung Bauermann
2016-08-11 23:08 ` [PATCH v5 13/13] powerpc: Enable CONFIG_KEXEC_FILE in powerpc server defconfigs Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edca3e4a-1901-eab4-6626-390c835b00c7@gmail.com \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bauerman@linux.vnet.ibm.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=stewart@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).