From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Arnd Bergmann" <arnd@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Hugh Dickins <hughd@google.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Maninder Singh <maninder1.s@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH 1/2] powerpc: mark more local variables as volatile
Date: Wed, 09 Aug 2023 15:35:46 +0200 [thread overview]
Message-ID: <eeeef65a-fbf9-403f-8541-5169b06976d7@app.fastmail.com> (raw)
In-Reply-To: <66ca8677-6a8d-c2f6-f215-a49ae7248458@csgroup.eu>
On Wed, Aug 9, 2023, at 15:17, Christophe Leroy wrote:
> Le 09/08/2023 à 15:10, Arnd Bergmann a écrit :
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> A while ago I created a2305e3de8193 ("powerpc: mark local variables
>> around longjmp as volatile") in order to allow building powerpc with
>> -Wextra enabled on gcc-11.
>
> Should this be explained in
> https://docs.kernel.org/process/volatile-considered-harmful.html ?
>
My feeling is that these two files are special enough that we
don't have to worry about it in general, there is only one other
caller of setjmp in the kernel, and the setjmp() man page
explicitly mentions this problem and the workaround.
Arnd
next prev parent reply other threads:[~2023-08-09 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:10 [PATCH 1/2] powerpc: mark more local variables as volatile Arnd Bergmann
2023-08-09 13:10 ` [PATCH 2/2] powerpc: xmon: remove unused variables Arnd Bergmann
2023-08-09 13:17 ` [PATCH 1/2] powerpc: mark more local variables as volatile Christophe Leroy
2023-08-09 13:35 ` Arnd Bergmann [this message]
2023-08-23 11:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeeef65a-fbf9-403f-8541-5169b06976d7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=gustavoars@kernel.org \
--cc=hughd@google.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maninder1.s@samsung.com \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).