From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/powermac: Simplify bootx_scan_dt_build_struct()
Date: Fri, 31 Jul 2026 09:11:21 +0200 [thread overview]
Message-ID: <ef09380b-feff-4891-83d7-19366681e8fb@kernel.org> (raw)
In-Reply-To: <20260720231453.117271-2-thorsten.blum@linux.dev>
Le 21/07/2026 à 01:14, Thorsten Blum a écrit :
> Assign the empty string directly instead of NULL checking namep again.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> arch/powerpc/platforms/powermac/bootx_init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c
> index 72eb99aba40f..abceae91dfde 100644
> --- a/arch/powerpc/platforms/powermac/bootx_init.c
> +++ b/arch/powerpc/platforms/powermac/bootx_init.c
> @@ -284,9 +284,7 @@ static void __init bootx_scan_dt_build_struct(unsigned long base,
> dt_push_token(OF_DT_BEGIN_NODE, mem_end);
>
> /* get the node's full name */
> - namep = np->full_name ? (char *)(base + np->full_name) : NULL;
> - if (namep == NULL)
> - namep = "";
> + namep = np->full_name ? (char *)(base + np->full_name) : "";
> l = strlen(namep);
>
> DBG("* struct: %s\n", namep);
prev parent reply other threads:[~2026-07-31 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 23:14 [PATCH] powerpc/powermac: Simplify bootx_scan_dt_build_struct() Thorsten Blum
2026-07-31 7:11 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef09380b-feff-4891-83d7-19366681e8fb@kernel.org \
--to=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox