From: Jiri Slaby <jirislaby@kernel.org>
To: ruanjinjie <ruanjinjie@huawei.com>,
gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tty: hvc: make hvc_rtas_dev static
Date: Thu, 20 Oct 2022 07:29:26 +0200 [thread overview]
Message-ID: <effb4a2a-2bdd-a4b7-f6db-948666515996@kernel.org> (raw)
In-Reply-To: <20221019064412.3759874-1-ruanjinjie@huawei.com>
On 19. 10. 22, 8:44, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/tty/hvc/hvc_rtas.c:29:19: warning: symbol 'hvc_rtas_dev' was
> not declared. Should it be static?
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
> drivers/tty/hvc/hvc_rtas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/hvc/hvc_rtas.c b/drivers/tty/hvc/hvc_rtas.c
> index e8b8c645482b..184d325abeed 100644
> --- a/drivers/tty/hvc/hvc_rtas.c
> +++ b/drivers/tty/hvc/hvc_rtas.c
> @@ -26,7 +26,7 @@
> #include "hvc_console.h"
>
> #define hvc_rtas_cookie 0x67781e15
> -struct hvc_struct *hvc_rtas_dev;
> +static struct hvc_struct *hvc_rtas_dev;
>
> static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
> static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
--
js
suse labs
prev parent reply other threads:[~2022-10-20 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 6:44 [PATCH -next] tty: hvc: make hvc_rtas_dev static ruanjinjie
2022-10-20 5:29 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=effb4a2a-2bdd-a4b7-f6db-948666515996@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).