linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: chris@distroguy.com
Subject: Re: [PATCH 1/3] selftests/powerpc: Remove Power9 copy_unaligned test
Date: Thu, 12 Jul 2018 12:00:47 +1000	[thread overview]
Message-ID: <f003a7aa17070a483aa66a80caa9c26f44639e9a.camel@neuling.org> (raw)
In-Reply-To: <20180711071017.5128-1-mpe@ellerman.id.au>

On Wed, 2018-07-11 at 17:10 +1000, Michael Ellerman wrote:
> This is a test of the ISA 3.0 "copy" instruction. That instruction has
> an L field, which if set to 1 specifies that "the instruction
> identifies the beginning of a move group" (pp 858). That's also
> referred to as "copy first" vs "copy".
>=20
> In ISA 3.0B the copy instruction does not have an L field, and the
> corresponding bit in the instruction must be set to 1.
>=20
> This test is generating a "copy" instruction, not a "copy first", and
> so on Power9 (which implements 3.0B), this results in an illegal
> instruction.
>=20
> So just drop the test entirely. We still have copy_first_unaligned to
> test the "copy first" behaviour.
>=20
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Michael Neuling <mikey@neuling.org>

  parent reply	other threads:[~2018-07-12  2:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11  7:10 [PATCH 1/3] selftests/powerpc: Remove Power9 copy_unaligned test Michael Ellerman
2018-07-11  7:10 ` [PATCH 2/3] selftests/powerpc: Remove Power9 paste tests Michael Ellerman
2018-07-12  2:00   ` Michael Neuling
2018-07-11  7:10 ` [PATCH 3/3] selftests/powerpc: Consolidate copy/paste test logic Michael Ellerman
2018-07-12  2:00 ` Michael Neuling [this message]
2018-07-23 15:11 ` [1/3] selftests/powerpc: Remove Power9 copy_unaligned test Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f003a7aa17070a483aa66a80caa9c26f44639e9a.camel@neuling.org \
    --to=mikey@neuling.org \
    --cc=chris@distroguy.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).