From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45436C433E0 for ; Wed, 17 Mar 2021 03:38:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 499A964F8F for ; Wed, 17 Mar 2021 03:38:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 499A964F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F0bTq4W1yz3bM7 for ; Wed, 17 Mar 2021 14:38:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.190; helo=szxga04-in.huawei.com; envelope-from=heying24@huawei.com; receiver=) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F0bTS5x3hz30GS for ; Wed, 17 Mar 2021 14:38:00 +1100 (AEDT) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F0bR23lJ8z19GBh; Wed, 17 Mar 2021 11:35:58 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Wed, 17 Mar 2021 11:37:45 +0800 Subject: Re: [PATCH] powerpc: arch/powerpc/kernel/setup_64.c - cleanup warnings To: Daniel Axtens , , , , , , , , , , References: <20210316041148.29694-1-heying24@huawei.com> <87wnu6bhvi.fsf@dja-thinkpad.axtens.net> From: "heying (H)" Message-ID: Date: Wed, 17 Mar 2021 11:37:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87wnu6bhvi.fsf@dja-thinkpad.axtens.net> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Thank you for your reply. ÔÚ 2021/3/17 11:04, Daniel Axtens дµÀ: > Hi He Ying, > > Thank you for this patch. > > I'm not sure what the precise rules for Fixes are, but I wonder if this > should have: > > Fixes: 9a32a7e78bd0 ("powerpc/64s: flush L1D after user accesses") > Fixes: f79643787e0a ("powerpc/64s: flush L1D on kernel entry") Is that necessary for warning cleanups? I thought 'Fixes' tags are needed only for bugfix patches. Can someone tell me whether I am right? > > Those are the commits that added the entry_flush and uaccess_flush > symbols. Perhaps one for rfi_flush too but I'm not sure what commit > introduced that. > > Kind regards, > Daniel > >> warning: symbol 'rfi_flush' was not declared. >> warning: symbol 'entry_flush' was not declared. >> warning: symbol 'uaccess_flush' was not declared. >> We found warnings above in arch/powerpc/kernel/setup_64.c by using >> sparse tool. >> >> Define 'entry_flush' and 'uaccess_flush' as static because they are not >> referenced outside the file. Include asm/security_features.h in which >> 'rfi_flush' is declared. >> >> Reported-by: Hulk Robot >> Signed-off-by: He Ying >> --- >> arch/powerpc/kernel/setup_64.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c >> index 560ed8b975e7..f92d72a7e7ce 100644 >> --- a/arch/powerpc/kernel/setup_64.c >> +++ b/arch/powerpc/kernel/setup_64.c >> @@ -68,6 +68,7 @@ >> #include >> #include >> #include >> +#include >> >> #include "setup.h" >> >> @@ -949,8 +950,8 @@ static bool no_rfi_flush; >> static bool no_entry_flush; >> static bool no_uaccess_flush; >> bool rfi_flush; >> -bool entry_flush; >> -bool uaccess_flush; >> +static bool entry_flush; >> +static bool uaccess_flush; >> DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); >> EXPORT_SYMBOL(uaccess_flush_key); >> >> -- >> 2.17.1 > .