From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 427F6F01832 for ; Fri, 6 Mar 2026 12:25:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fS5Gq5Sfbz3c9x; Fri, 06 Mar 2026 23:25:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772799480; cv=none; b=a4UuVxaB0oRS38I8oAh8Hw8gZYMUrntxPgJhdmQoAN3CcYwEyU2qeHZvJx3S8I47zDtRPBMkyTNXPkNWwYuCgudqtI1hWFObMfa1oGLwkPmTem1owXEcccQeX+SmVGNb9ODidKaYrP3/gqmoSRhv5SvE0lRnWQuMck9Gx0rfD9dYDLwWxjd3t3ntmzQNgp4kLgSkUqcZabg5u3QRhE74Pd1wYxxXb9s1Bhr/yiJYlER+WpynWWwuhHPpIsG1yla1zhYIEcXsHzld4XKc9CtSuObJWW6HUh5q2SgL+ENWenCRGXqa9/48INIFpm6KkUEswhNUmLuBoWYL6GIdrTe7pA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772799480; c=relaxed/relaxed; bh=rsecX7IfEkl6mg+kpO6NHs6lMEsEKwri/xBkvNiB/E4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3yPSJixM1baiHR4EQGgwXwh0Ee34yR3JAdwR3Rd9zBNOhmDiK3tHnABszn3WATKAQGHJYwy2RijjH8I+8Qjqehq+svrNb/jdC/80q7IfJyXTcfd6enG9muIz8KdIPWDMVd1XgzebqvMXqKH08qNcGGGTs5SveVrFKHelSrMBZQHCKKusMtTvw0ugtLeI6uH7P6Bbj+jwi/ZeXsYK0DWIUCnrzIvG8xDE9Jsr14eeGn7EnuyuM/FaTqvEO6GcbkxmXxr4ApsaNoxfzXYq6m9Q+KsW2SQiitw89yOL41fXOsCpuxvfcPs85lP4tGlBTDzcr1Tft4xXCisPaSZYMS3ow== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=rCp0TEPy; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=rCp0TEPy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=ljs@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fS55g6nMhz30T9 for ; Fri, 06 Mar 2026 23:17:59 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 3D6E3404AF; Fri, 6 Mar 2026 12:17:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 811D4C4CEF7; Fri, 6 Mar 2026 12:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772799478; bh=yyADghSRuv3g36SG1gTJ+zwspTahcSZlQ722wYwHmFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rCp0TEPyTOAJupRC28UvQbYXcao/G55MgmxFJIUwmwhQpuaPUpOT9IaUxiz4l5nEc otvkysRzxPs3DwlOKdKiqY//hgQr7LqJ9BEez9xlbH2rOvQ6KR8wW1Te2DyXt5Y7C0 AdZO6ELl5OOGQXFL+vy+jJZnK0vGap6Hkyknjo+SAeXBT8O22MNov+m6lrTpzBgLZQ EhmCORIlTz+NSzc9TcBguQTQ6X0MFO8+HpR8ALVK04Q+cBoY+dyiAu0NzOviSlR6nv hBCmb0cqI2vr+citiZrZ/w8gPppkTAUyT1n6sGgxa1kceA0/E1psbkUc1vZ34fDFyh JYwVuJUUBth/A== Date: Fri, 6 Mar 2026 12:17:55 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Alice Ryhl , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v1 07/16] mm/memory: rename unmap_single_vma() to __zap_vma_range() Message-ID: References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-8-david@kernel.org> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227200848.114019-8-david@kernel.org> On Fri, Feb 27, 2026 at 09:08:38PM +0100, David Hildenbrand (Arm) wrote: > Let's rename it to better fit our new naming scheme. > > Signed-off-by: David Hildenbrand (Arm) Yesssss thank you! I hate[d] the rando 'sometimes zap sometimes unmap' naming convention here. LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > mm/memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 621f38ae1425..f0aaec57a66b 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2074,7 +2074,7 @@ static void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > } > > > -static void unmap_single_vma(struct mmu_gather *tlb, > +static void __zap_vma_range(struct mmu_gather *tlb, > struct vm_area_struct *vma, unsigned long start_addr, > unsigned long end_addr, struct zap_details *details) > { > @@ -2177,7 +2177,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct unmap_desc *unmap) > unsigned long start = unmap->vma_start; > unsigned long end = unmap->vma_end; > hugetlb_zap_begin(vma, &start, &end); > - unmap_single_vma(tlb, vma, start, end, &details); > + __zap_vma_range(tlb, vma, start, end, &details); > hugetlb_zap_end(vma, &details); > vma = mas_find(unmap->mas, unmap->tree_end - 1); > } while (vma); > @@ -2213,7 +2213,7 @@ void zap_page_range_single_batched(struct mmu_gather *tlb, > * unmap 'address-end' not 'range.start-range.end' as range > * could have been expanded for hugetlb pmd sharing. > */ > - unmap_single_vma(tlb, vma, address, end, details); > + __zap_vma_range(tlb, vma, address, end, details); > mmu_notifier_invalidate_range_end(&range); > if (is_vm_hugetlb_page(vma)) { > /* > -- > 2.43.0 >