From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.variantweb.net (unknown [104.131.199.242]) by lists.ozlabs.org (Postfix) with ESMTP id 67EE81A03D5 for ; Fri, 17 Oct 2014 19:04:57 +1100 (AEDT) Message-ID: In-Reply-To: <1413499949.4567.3.camel@pasglop> References: <1413487819-6119-1-git-send-email-ddstreet@ieee.org> <1413499435.28062.2.camel@concordia> <1413499949.4567.3.camel@pasglop> Date: Fri, 17 Oct 2014 07:59:52 -0000 Subject: Re: [PATCH] drivers/crypto/nx: prevent oops on module exit From: "Seth Jennings" To: "Benjamin Herrenschmidt" Reply-To: sjennings@variantweb.net MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, Seth Jennings , Dan Streetman , Robert Jennings List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: >> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: >> > Check old_devdata->dev in nx-842 driver before accessing it, as >> > on systems without any nx-842 hardware, the ->dev will never be >> > set. Currently, the module will cause an oops during unload >> > since old_devdata->dev is null. >> >> Hi Dan, >> >> Patch looks reasonable. But I can't merge it, at least not without an >> ACK: >> >> $ ./scripts/get_maintainer.pl -f drivers/crypto/nx/ >> Nathan Fontenot (supporter:IBM Power 842 >> com...) >> Marcelo Henrique Cerri (supporter:IBM Power >> in-Nest...) >> Fionnuala Gunter (supporter:IBM Power >> in-Nest...) >> Herbert Xu (maintainer:CRYPTO API) >> "David S. Miller" (maintainer:CRYPTO API) >> linux-crypto@vger.kernel.org (open list:IBM Power in-Nest...) >> linux-kernel@vger.kernel.org (open list) >> >> >> If any of the above is out of date please send me a patch for >> MAINTAINERS. > > I think Dan now owns that driver, Dan, please confirm. I guess I'm not on the maintainer list anymore, as I shouldn't be since I don't work at IBM anymore. So... yeah. I was the original co-author of driver so I acked it but I'm not the maintainer anymore. Which I shouldn't be, since I don't work at IBM anymore. Seth > > Cheers, > Ben. > > >