From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E48BFC55160 for ; Thu, 30 Jul 2026 12:05:28 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4h9nvq1pCKz2yYd; Thu, 30 Jul 2026 22:05:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785413127; cv=none; b=dv0mbWuG1qAWrSkHdu9rhjGOB6Zixfr/HJek2ZpNlApdLzRFsHd4xPq5TL+ONYUiKvnKd3awx4oz+zcYmrQuFq0iLCiAL2vW1ot6p5fyAiWv3srwtfwAwR5pNDC/dmA1Zoqb5EWh3S3X4cSwRh9f39+nbfUEQqu/tD5bO823qBmMBRMNpfqwILTYcZ9yEMnuuO7QpM/wLaMYEtcXUwk1Uf7783mklruByr9yVvZSnaImllVoe+FpXNjMIF9hYH1W0Iq0diw3OHV8XQsBgYBRZQANl91UIVrmk+L34C7Ade6r0+X2Cnyl1S6XJeVdEOLWkcTu6xY7CyWLyye/LFMWrw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1785413127; c=relaxed/relaxed; bh=GB+1/VcAurLNVMM5ndJqiyvxdLgZ7zdkHDifPc4bAgQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=itUffbmMXnTtiVTVCT5wl2QiXz8JzhlzV4KVTObxaSrEeufT1yHSH0HbRrptGnemWC4SZOF14uIuyOHubk1qq5SsI9yy5keLgv8NMF90KysQnYTqKUQqULcX4SzFHHuwVpGq+xSlpVD3MJaB+cX7rdaZtou4Zr5TJSLjNS+x44WZZM2Nw9EVnDzDxDgjuFfbscVCMCCDqRw7rR9IFgmjjmi13IKZ8lKiLtgXkfN5kjHDUnDBqfRiizYT4KxPxGai0NSToHkfUJ2rRxx2FBqaLyRB4OeNEjOi00V9GJTRxLawqKvp/AnQG+zGxeZK4+h+R8vg+QkpyFvghyQ0NAGdoQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=NLwNWWae; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=NLwNWWae; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4h9nvp3Q9nz2xnp for ; Thu, 30 Jul 2026 22:05:26 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id EE7A041771; Thu, 30 Jul 2026 12:05:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C68F1F000E9; Thu, 30 Jul 2026 12:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785413123; bh=GB+1/VcAurLNVMM5ndJqiyvxdLgZ7zdkHDifPc4bAgQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=NLwNWWaeMvG01Gjpp7uMwgO9G7vUki4N/1xrJ4tu5DCJcxUNDllGTq5yEwLkd30eI HQg/Nm7ekIhMETcHlPO7MqTHuqIWpWsGamPgw3MVuB3MvhpOoFpEMhbToygWKw/Akh kCEBQ4krd/HJqHV6SUOa2rKpSQpqUfIPOrAi8tQ4GEf5XfUySrOGTMQsEBR+x95UYp juSeKcWDcem0HsFiloMpB2R+Xxn4IK8MXcOgNP5Pxo5aT3EITt4TDIfeowUe78nmQx Up1HCJ3dKR4Iuxob+xdwf4iVRjFlGMC3unZZcQkCWyD9kLzm7+JsXHK0TJPrD46aLx wQ/kZdTsnuXCA== Message-ID: Date: Thu, 30 Jul 2026 14:05:19 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: fsl: qe: properly scan GPIO nodes at startup To: "Christophe Leroy (CS GROUP)" Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Herve Codina , Paul Louvel References: <04dc047f8958a78a920f0a88ca3bd8bf70c56187.1785333986.git.chleroy@kernel.org> <223afb76-9f6f-48a1-a5c5-beb1a641916c@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <223afb76-9f6f-48a1-a5c5-beb1a641916c@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/07/2026 14:01, Christophe Leroy (CS GROUP) wrote: > > > Le 30/07/2026 à 13:14, Krzysztof Kozlowski a écrit : >> On 29/07/2026 16:10, Christophe Leroy (CS GROUP) wrote: >>> Before commit 156460811def ("soc: fsl: qe: Change GPIO driver to a >>> proper platform driver") qe_add_gpiochips() was walking the device >>> tree to find all nodes with compatible "fsl,mpc8323-qe-pario-bank". >>> >>> After that commit the discovery is handled by the platform core, >>> therefore it is necessary to call of_platform_default_populate() on >>> the par_io node. >>> >>> Fixes: 156460811def ("soc: fsl: qe: Change GPIO driver to a proper platform driver") >>> Signed-off-by: Christophe Leroy (CS GROUP) >>> --- >>> drivers/soc/fsl/qe/qe_io.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/drivers/soc/fsl/qe/qe_io.c b/drivers/soc/fsl/qe/qe_io.c >>> index a5e2d0e5ab51..02ca556c8db0 100644 >>> --- a/drivers/soc/fsl/qe/qe_io.c >>> +++ b/drivers/soc/fsl/qe/qe_io.c >>> @@ -15,6 +15,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include >>> #include >>> @@ -184,3 +185,17 @@ int par_io_of_config(struct device_node *np) >>> return 0; >>> } >>> EXPORT_SYMBOL(par_io_of_config); >>> + >>> +static int __init par_io_populate(void) >>> +{ >>> + struct device_node *np = of_find_node_by_name(NULL, "par_io"); >> >> No, node name must not be ABI. Especially wrong node name. > > What's wrong with the node name ? 1. It causes W=2 warnings (which we might move to W=1 at some point) 2. It is not generic and DT spec asks for generic node names, although maybe this part of code follows more of ePAPR than DT. But ePAPR v1.1 also was asking for generic node names. > > Regardless, I messed it up, I wanted to use type but copy/pasted > of_find_node_by_name(NULL, "par_io") from quirk_mpc8360e_qe_enet10() in > arch/powerpc/platforms/83xx/km83xx.c instead. > > Is it OK to use of_find_node_by_type(NULL, "par_io") instead ? Well, depends. Is it a documented ABI? > > We have: > > $ git grep par_io arch/powerpc/boot/dts/ > arch/powerpc/boot/dts/fsl/mpc8568mds.dts: par_io@e0100 { > arch/powerpc/boot/dts/fsl/mpc8568si-post.dtsi: par_io@e0100 { > arch/powerpc/boot/dts/fsl/mpc8568si-post.dtsi: device_type = > "par_io"; These are all DTS, does not matter really. ABI is not documented via DTS but bindings. Best regards, Krzysztof