From: Aleksa Sarai <asarai@suse.de>
To: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <christian.brauner@ubuntu.com>,
Valentin Rothberg <vrothberg@suse.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-mips@linux-mips.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition
Date: Tue, 11 Jul 2017 12:07:43 +1000 [thread overview]
Message-ID: <f1cac5bf-d34f-9684-b27b-20e973f454a0@suse.de> (raw)
In-Reply-To: <20170711001207.GA11642@glebfm.cloud.tilaa.com>
> This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag
> because it doesn't copy anything from/to userspace to access the
> argument.
Acked-by: Aleksa Sarai <asarai@suse.de>
Oops, I misunderstood what _IOR means semantically. TIL -- thanks!
--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
next prev parent reply other threads:[~2017-07-11 2:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 0:12 [PATCH] tty: Fix TIOCGPTPEER ioctl definition Gleb Fotengauer-Malinovskiy
2017-07-11 2:07 ` Aleksa Sarai [this message]
2017-07-11 7:30 ` Arnd Bergmann
2017-07-11 10:03 ` James Hogan
2017-07-11 14:23 ` David Laight
2017-07-11 14:45 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1cac5bf-d34f-9684-b27b-20e973f454a0@suse.de \
--to=asarai@suse.de \
--cc=arnd@arndb.de \
--cc=christian.brauner@ubuntu.com \
--cc=glebfm@altlinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=ldv@altlinux.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=vrothberg@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).