From: Dan Malek <dan@embeddededge.com>
To: Pantelis Antoniou <panto@intracom.gr>
Cc: Tom Rini <trini@kernel.crashing.org>,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver
Date: Tue, 10 May 2005 08:13:48 -0400 [thread overview]
Message-ID: <f1e15a8d9ed033e850b56ca965754a43@embeddededge.com> (raw)
In-Reply-To: <4280985D.80108@intracom.gr>
On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote:
> This patch replace iopa use with virt_to_phys.
Not gonna work .....
When you map uncached on 8xx you get a new vmalloc()
space. The virt_to_xxx macros don't work on those addresses.
You need to use the dma_consistent() function, stash the
real physical address it returns and then use it where
appropriate.
> + W32(ep, fen_genfcc.fcc_rbase, virt_to_phys(fep->rx_bd_base));
> + W32(ep, fen_genfcc.fcc_tbase, virt_to_phys(fep->tx_bd_base));
I thought you were getting rid of these weirdo macros and
write normal code for data structure access? Please .....
Thanks.
-- Dan
next prev parent reply other threads:[~2005-05-10 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 11:45 [PATCH 03/04] Freescale Ethernet combined driver Pantelis Antoniou
2005-05-09 20:38 ` Matt Porter
2005-05-10 11:17 ` Pantelis Antoniou
2005-05-10 12:13 ` Dan Malek [this message]
2005-05-10 12:15 ` Pantelis Antoniou
2005-05-10 13:27 ` Matt Porter
2005-05-10 13:14 ` Pantelis Antoniou
2005-05-10 13:47 ` Matt Porter
2005-05-10 13:36 ` Pantelis Antoniou
2005-05-12 9:37 ` Pantelis Antoniou
2005-05-13 8:51 ` Pantelis Antoniou
2005-05-10 18:14 ` Dan Malek
-- strict thread matches above, loose matches on Subject: below --
2005-05-10 14:53 Rune Torgersen
2005-05-10 18:24 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e15a8d9ed033e850b56ca965754a43@embeddededge.com \
--to=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=panto@intracom.gr \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).