From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.228]) by ozlabs.org (Postfix) with ESMTP id 78F98DDDA0 for ; Wed, 18 Feb 2009 23:01:36 +1100 (EST) Received: by rv-out-0506.google.com with SMTP id g9so5303200rvb.1 for ; Wed, 18 Feb 2009 04:01:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <499AF08B.6010702@freescale.com> References: <20090216180857.GA18069@ld0162-tx32.am.freescale.net> <499AF08B.6010702@freescale.com> Date: Wed, 18 Feb 2009 17:31:34 +0530 Message-ID: Subject: Re: Regarding irq_of_parse_and_map From: Vijay Nikam To: linuxppc-dev@ozlabs.org Content-Type: text/plain; charset=ISO-8859-1 Cc: Scott Wood List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , I checked and read the Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt and booting-without-of.txt. It is different then what I read before from booting-without-of.txt ... perhaps as it is old and came with BSP. Am I right ? ? ? > Don't specify this explicitly. Please base new development off of the > device tree that is in upstream Linux, not the very old tree in your BSP. May I know the reason why I should not specify it explicitly ? ? ? Also what would be the problem if I do in the same way as it is given in BSP mpc8313erdb.dts ? ? ? And should I use gpio-controller as a gpio device node ? ? ? Kindly please acknowledge ... thank you ... Kind Regards, Vijay Nikam On 2/17/09, Scott Wood wrote: > Vijay Nikam wrote: > > I added the gpio node as follows to mpc8313erdb.dts; > > > > gpio@c00 { > > linux,phandle = ; > > > > Don't specify this explicitly. Please base new development off of the > device tree that is in upstream Linux, not the very old tree in your BSP. > > > device_type = "gpio"; > > > > No device_type. > > > The only thing I need to know what should I write at 'compatible' tag > > ? ? ? the compatible tag format is "manufacturer,model" the > > manufacturer is 'fsl' i.e. I think freescale but the model, as it is > > the model number where I can find this model ? ? ? Please let me know > > ... thanks ... > > > > compatible = "fsl,mpc8313-gpio", "fsl,mpc8349-gpio"; > > > Also I would like to ask if the above device node is written according > > to bindings ... I think it should be right as I referred > > 'bootingwithout-of.txt' ... but please correct me if I am worng ? ? ? > > > > See also > Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt. > > Also note that current Linux has a driver in > arch/powerpc/sysdev/mpc8xxx_gpio.c. > > -Scott >