From: Milton Miller <miltonm@bga.com>
To: Nathan Lynch <ntl@pobox.com>
Cc: linux-ppc <linuxppc-dev@ozlabs.org>
Subject: Re: badness in xics_set_cpu_giq on JS20 blade
Date: Sat, 22 Nov 2008 10:30:38 -0600 [thread overview]
Message-ID: <f35ce64a4d02ccbf84d3288dad3dc0f8@bga.com> (raw)
In-Reply-To: <20081122030653.GU6830@localdomain>
On Sat Nov 22 at 14:06:53 EST in 2008, Nathan Lynch wrote:
> With 2.6.28-rc5 the WARN_ON in xics_set_cpu_giq is triggering on a
> JS20. I changed it to a WARN to get the actual status returned:
>
> [boot]0020 XICS Init
> set-indicator returned -22
> ------------[ cut here ]------------
> Badness at arch/powerpc/platforms/pseries/xics.c:733
...
> Call Trace:
> [c0000000006b3ca0] [c000000000047450] .xics_set_cpu_giq+0x50/0x68
> (unreliable)
> [c0000000006b3d10] [c0000000005927b8] .xics_init_IRQ+0x2f4/0x338
> [c0000000006b3de0] [c000000000591bcc] .pseries_xics_init_IRQ+0x14/0x2c
> [c0000000006b3e60] [c000000000580488] .init_IRQ+0x40/0x5c
> [c0000000006b3ee0] [c0000000005787d8] .start_kernel+0x250/0x478
> [c0000000006b3f90] [c0000000000083b8] .start_here_common+0x1c/0x64
...
> -22 is -EINVAL, which maps to a -3 return code from RTAS (see
> rtas_error_rc).
>
> The system appears to boot and function normally after this, though.
> FWIW, it looks like its firmware is up to date (FW08401160 from March
> 2008).
b4963255ad5a426f04a0bb15c4315fa4bb40cde9 "Factor out cpu
joining/unjoining the GIQ" consolidated the join and remove call sites.
Looking closer it also added warn if rtas-indicator returned an error
on join in addition to leave.
I don't have my PAPR here, but from rtas_error_rc (rtas.c) -3 is /* Bad
indicator/domain/etc */. This indicator was added to support cpu add
and remove. I'm guessing js20 doesn't support that from rtas (ie
doesn't support cpu hotadd), and the indicator is not available. (I
know js21 has it because I had a bit of time to see its broken
emulation of this call once).
When we get control of a cpu from OF it is already in the joined state.
We join on all threads because we need to do so on secondary threads
and because we did a remove on (previously all, but now secondary)
threads during kexec.
If memory serves, there is a property in the rtas node to indicate each
sensor that is present. If so, we should search for that property
before calling set-indicator.
milton
next prev parent reply other threads:[~2008-11-22 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 3:06 badness in xics_set_cpu_giq on JS20 blade Nathan Lynch
2008-11-22 16:30 ` Milton Miller [this message]
2008-11-23 0:26 ` Nathan Lynch
2008-11-25 16:31 ` Milton Miller
2008-12-11 19:14 ` [PATCH] check for GIQ indicator before calling set-indicator Nathan Lynch
2008-12-13 20:22 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35ce64a4d02ccbf84d3288dad3dc0f8@bga.com \
--to=miltonm@bga.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).