immap with 8xx.

immap with 8xx.

[Ingo Hornberger]

Hi,

I'm currently porting an old 2.4 kernel driver to 2.6.14. I got some
problems with the immap and idma stuff. The driver is very special and
uses it's own dma handling, because it's too different from the default.

So it strongly depends on the underlying hardware. (In this case 8xx)

With kernel 2.4 it used the headers:
- asm/commproc.h
- asm/8xx_immap.h

But it seems that there was some generalization work done, which didn't
reach the 8xx part. Particularly this means that some parts of
'asm/commproc.h' as well as (at least) 'asm/immap_8260.h' built up a new
header 'asm/immap_cpm2.h'.

Actally I miss a file like 'asm/immap_cpm1.h'.
If it would be the right solution to create a file like this, that's no
problem. I only wanted to make sure that I don't do duplicated work this
time.

regards,
	Ingo

Re: immap with 8xx.

[Dan Malek]

On Nov 29, 2005, at 9:39 AM, Ingo Hornberger wrote:

> But it seems that there was some generalization work done, which didn't
> reach the 8xx part. Particularly this means that some parts of
> 'asm/commproc.h' as well as (at least) 'asm/immap_8260.h' built up a 
> new
> header 'asm/immap_cpm2.h'.

That's because the cpm2 is used in more parts than just the 82xx,
so we carved up the files to make it more useful.

> Actally I miss a file like 'asm/immap_cpm1.h'.

The 8xx is the only processor to use the CPM1, so just update
the immap or 8xx files to accommodate the differences you may
need.  There isn't a similar requirement to create a immap_cpm1.h
file like there was for the CPM2.  What kind of updates do you need?

Thanks.

	-- Dan

Re: immap with 8xx.

[Ingo Hornberger]

Thanks Dan for your reply!

I mainly needed the immap stuff like 'immap_rp_t' and some 'defines'.

But I just started to reorder this. I thought that 'cpm1' and 'cpm2'
devices should follow the same unique scheme, shouldn't they? Even if we
only have one cpm1 device.

Otherwise the naming is very confusing.
For example:
(8xx)     	(cpm2)
commproc.h	cpm2.h
8xx_immap.h	immap_cpm2.h
immap_t  	cpm2_map_t
iop8xx_t	iop_cpm2_t
...       	...

And because the cpm2 scheme is newer and cleaner, I think we should use
that instead.
This change would mainly rename the following files (and their symbols):
8xx_immap.h -> immap_cpm1.h
commproc.h  -> cpm1.h
(but likely affect others, too)

Then we would need three patches:
1. rename the files
2. patch only the 'include/asm' files
3. rename all "#include" directives and symbols in the rest.

Or do you see too much problems in renaming such symbols? Perhaps this
should be a topic for the development kernel, but I don't think so...

I think we should do this now, because it's only relevant for low-level
8xx code (and drivers like mine or the ide driver). The init code could
be converted by us, and as the 8xx port of 2.6 isn't such old and stable
I believe that there are not too much (if none) already ported drivers
around that are using low-level 8xx stuff.

But I'd like to here more opinions.

regards,
	Ingo

On Tue, 2005-11-29 at 13:13 -0500, Dan Malek wrote:
> On Nov 29, 2005, at 9:39 AM, Ingo Hornberger wrote:
> 
> > But it seems that there was some generalization work done, which didn't
> > reach the 8xx part. Particularly this means that some parts of
> > 'asm/commproc.h' as well as (at least) 'asm/immap_8260.h' built up a 
> > new
> > header 'asm/immap_cpm2.h'.
> 
> That's because the cpm2 is used in more parts than just the 82xx,
> so we carved up the files to make it more useful.
> 
> > Actally I miss a file like 'asm/immap_cpm1.h'.
> 
> The 8xx is the only processor to use the CPM1, so just update
> the immap or 8xx files to accommodate the differences you may
> need.  There isn't a similar requirement to create a immap_cpm1.h
> file like there was for the CPM2.  What kind of updates do you need?
> 
> Thanks.
> 
> 	-- Dan
>