[PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Krzysztof Kozlowski]

Return value of ps3_start_probe_thread() is not used, so code can be
simplified to fix W=1 clang warnings:

  arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---

Resend after ~2.5 months

 arch/powerpc/platforms/ps3/device-init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/ps3/device-init.c b/arch/powerpc/platforms/ps3/device-init.c
index 12c473768c39..9109c218a060 100644
--- a/arch/powerpc/platforms/ps3/device-init.c
+++ b/arch/powerpc/platforms/ps3/device-init.c
@@ -950,8 +950,6 @@ static int __init ps3_start_probe_thread(enum ps3_bus_type bus_type)
 
 static int __init ps3_register_devices(void)
 {
-	int result;
-
 	if (!firmware_has_feature(FW_FEATURE_PS3_LV1))
 		return -ENODEV;
 
@@ -959,7 +957,7 @@ static int __init ps3_register_devices(void)
 
 	/* ps3_repository_dump_bus_info(); */
 
-	result = ps3_start_probe_thread(PS3_BUS_TYPE_STORAGE);
+	ps3_start_probe_thread(PS3_BUS_TYPE_STORAGE);
 
 	ps3_register_vuart_devices();
 
-- 
2.51.0

[PATCH RESEND 2/2] powerpc/pasemi: Drop redundant res assignment

[Krzysztof Kozlowski]

Return value of pas_add_bridge() is not used, so code can be simplified
to fix W=1 clang warnings:

  arch/powerpc/platforms/pasemi/pci.c:275:6: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---

Resend after ~2.5 months

 arch/powerpc/platforms/pasemi/pci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
index 60f990a336c4..2df955274652 100644
--- a/arch/powerpc/platforms/pasemi/pci.c
+++ b/arch/powerpc/platforms/pasemi/pci.c
@@ -272,13 +272,12 @@ void __init pas_pci_init(void)
 {
 	struct device_node *root = of_find_node_by_path("/");
 	struct device_node *np;
-	int res;
 
 	pci_set_flags(PCI_SCAN_ALL_PCIE_DEVS);
 
 	np = of_find_compatible_node(root, NULL, "pasemi,rootbus");
 	if (np) {
-		res = pas_add_bridge(np);
+		pas_add_bridge(np);
 		of_node_put(np);
 	}
 	of_node_put(root);
-- 
2.51.0

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Geert Uytterhoeven]

On Tue, 17 Mar 2026 at 14:15, Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
> Return value of ps3_start_probe_thread() is not used, so code can be
> simplified to fix W=1 clang warnings:
>
>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Segher Boessenkool]

On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
> Return value of ps3_start_probe_thread() is not used, so code can be
> simplified to fix W=1 clang warnings:
> 
>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]

And this is exactly why -Werror is harmful.  A boring harmless warning
turned into a build break :-(

You can sometimes usefully turn *some* warnings into errors, and any
user is of course free to invite as much pain as he or she wants to
bear, but heaping nonsense like this onto unsuspecting users is just
evil.  And it is even worse when the warnings can change with compiler
version!


Segher

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Krzysztof Kozlowski]

On 18/03/2026 12:51, Segher Boessenkool wrote:
> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>> Return value of ps3_start_probe_thread() is not used, so code can be
>> simplified to fix W=1 clang warnings:
>>
>>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
> 
> And this is exactly why -Werror is harmful.  A boring harmless warning
> turned into a build break :-(

-Werror does not matter here. We do not want warnings either, assuming
of course they are correct.

So if this warning is correct, then patch should be applied and WERROR
is irrelevant.

Best regards,
Krzysztof

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Segher Boessenkool]

On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2026 12:51, Segher Boessenkool wrote:
> > On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
> >> Return value of ps3_start_probe_thread() is not used, so code can be
> >> simplified to fix W=1 clang warnings:
> >>
> >>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
> > 
> > And this is exactly why -Werror is harmful.  A boring harmless warning
> > turned into a build break :-(
> 
> -Werror does not matter here. We do not want warnings either, assuming
> of course they are correct.
> 
> So if this warning is correct, then patch should be applied and WERROR
> is irrelevant.

The build is broken.  -Werror is positively harmful.

Yes, you want the warnings fixed, but maybe something else has priority
right now?


Segher

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Krzysztof Kozlowski]

On 18/03/2026 12:58, Segher Boessenkool wrote:
> On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
>> On 18/03/2026 12:51, Segher Boessenkool wrote:
>>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>>>> Return value of ps3_start_probe_thread() is not used, so code can be
>>>> simplified to fix W=1 clang warnings:
>>>>
>>>>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>>>
>>> And this is exactly why -Werror is harmful.  A boring harmless warning
>>> turned into a build break :-(
>>
>> -Werror does not matter here. We do not want warnings either, assuming
>> of course they are correct.
>>
>> So if this warning is correct, then patch should be applied and WERROR
>> is irrelevant.
> 
> The build is broken.  -Werror is positively harmful.
> 
> Yes, you want the warnings fixed, but maybe something else has priority
> right now?

What do you mean? This is waiting on the list for long time - note that
it is a resend - so if warning is correct, for how long it should wait
to get to the "priority" box?

And why anything needs even the priority here? Why priority has to be
discussed, especially for some legacy (I think?) code? Why correct
patches cannot be simply applied after some time/review?


Best regards,
Krzysztof

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Segher Boessenkool]

On Wed, Mar 18, 2026 at 01:03:03PM +0100, Krzysztof Kozlowski wrote:
> On 18/03/2026 12:58, Segher Boessenkool wrote:
> > On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
> >> On 18/03/2026 12:51, Segher Boessenkool wrote:
> >>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
> >>>> Return value of ps3_start_probe_thread() is not used, so code can be
> >>>> simplified to fix W=1 clang warnings:
> >>>>
> >>>>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
> >>>
> >>> And this is exactly why -Werror is harmful.  A boring harmless warning
> >>> turned into a build break :-(
> >>
> >> -Werror does not matter here. We do not want warnings either, assuming
> >> of course they are correct.
> >>
> >> So if this warning is correct, then patch should be applied and WERROR
> >> is irrelevant.
> > 
> > The build is broken.  -Werror is positively harmful.
> > 
> > Yes, you want the warnings fixed, but maybe something else has priority
> > right now?
> 
> What do you mean? This is waiting on the list for long time - note that
> it is a resend - so if warning is correct, for how long it should wait
> to get to the "priority" box?
> 
> And why anything needs even the priority here? Why priority has to be
> discussed, especially for some legacy (I think?) code? Why correct
> patches cannot be simply applied after some time/review?

It is totally simple: without -Werror, you can build a kernel.  With it,
you cannot.

The ***warning*** is correct, there is something in the code that can be
improved.  That is why such things are warnings: the compiler can
produce useful output, there is no reason to scream bloody murder.

The main reason some people like -Werror is because they are too lazy to
look at the warning messages they get from normal builds.  Such
developers need potty training, this is not a reason to punish all more
reasonable people!


Segher

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Christophe Leroy (CS GROUP)]

Le 18/03/2026 à 12:58, Segher Boessenkool a écrit :
> On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
>> On 18/03/2026 12:51, Segher Boessenkool wrote:
>>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>>>> Return value of ps3_start_probe_thread() is not used, so code can be
>>>> simplified to fix W=1 clang warnings:
>>>>
>>>>    arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>>>
>>> And this is exactly why -Werror is harmful.  A boring harmless warning
>>> turned into a build break :-(
>>
>> -Werror does not matter here. We do not want warnings either, assuming
>> of course they are correct.
>>
>> So if this warning is correct, then patch should be applied and WERROR
>> is irrelevant.
> 
> The build is broken.  -Werror is positively harmful.
> 
> Yes, you want the warnings fixed, but maybe something else has priority
> right now?

But if I understand correctly this is a build performed with W=1

Without W=1 there is no build breakage.

Someone who forces W=1 on its build can be expected to unselect 
CONFIG_PPC_WERROR if it is needed for him, no ?

Christophe

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Krzysztof Kozlowski]

On 18/03/2026 13:12, Segher Boessenkool wrote:
> On Wed, Mar 18, 2026 at 01:03:03PM +0100, Krzysztof Kozlowski wrote:
>> On 18/03/2026 12:58, Segher Boessenkool wrote:
>>> On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
>>>> On 18/03/2026 12:51, Segher Boessenkool wrote:
>>>>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>>>>>> Return value of ps3_start_probe_thread() is not used, so code can be
>>>>>> simplified to fix W=1 clang warnings:
>>>>>>
>>>>>>   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>>>>>
>>>>> And this is exactly why -Werror is harmful.  A boring harmless warning
>>>>> turned into a build break :-(
>>>>
>>>> -Werror does not matter here. We do not want warnings either, assuming
>>>> of course they are correct.
>>>>
>>>> So if this warning is correct, then patch should be applied and WERROR
>>>> is irrelevant.
>>>
>>> The build is broken.  -Werror is positively harmful.
>>>
>>> Yes, you want the warnings fixed, but maybe something else has priority
>>> right now?
>>
>> What do you mean? This is waiting on the list for long time - note that
>> it is a resend - so if warning is correct, for how long it should wait
>> to get to the "priority" box?
>>
>> And why anything needs even the priority here? Why priority has to be
>> discussed, especially for some legacy (I think?) code? Why correct
>> patches cannot be simply applied after some time/review?
> 
> It is totally simple: without -Werror, you can build a kernel.  With it,
> you cannot.

What are you discussing here? This is a patch, not WERROR talk.

> 
> The ***warning*** is correct, there is something in the code that can be
> improved.  That is why such things are warnings: the compiler can
> produce useful output, there is no reason to scream bloody murder.
> 
> The main reason some people like -Werror is because they are too lazy to
> look at the warning messages they get from normal builds.  Such
> developers need potty training, this is not a reason to punish all more
> reasonable people!
How is this relevant to this warning?

Best regards,
Krzysztof

Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

[Krzysztof Kozlowski]

On 18/03/2026 13:21, Christophe Leroy (CS GROUP) wrote:
> 
> 
> Le 18/03/2026 à 12:58, Segher Boessenkool a écrit :
>> On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote:
>>> On 18/03/2026 12:51, Segher Boessenkool wrote:
>>>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote:
>>>>> Return value of ps3_start_probe_thread() is not used, so code can be
>>>>> simplified to fix W=1 clang warnings:
>>>>>
>>>>>    arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]
>>>>
>>>> And this is exactly why -Werror is harmful.  A boring harmless warning
>>>> turned into a build break :-(
>>>
>>> -Werror does not matter here. We do not want warnings either, assuming
>>> of course they are correct.
>>>
>>> So if this warning is correct, then patch should be applied and WERROR
>>> is irrelevant.
>>
>> The build is broken.  -Werror is positively harmful.
>>
>> Yes, you want the warnings fixed, but maybe something else has priority
>> right now?
> 
> But if I understand correctly this is a build performed with W=1

Yes

> 
> Without W=1 there is no build breakage.

There is no build breakage with W=1.

This is somehow total offtopic or trolling. :/

> 
> Someone who forces W=1 on its build can be expected to unselect 
> CONFIG_PPC_WERROR if it is needed for him, no ?

Of course :).


Best regards,
Krzysztof