From: Paolo Bonzini <pbonzini@redhat.com>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
mpe@ellerman.id.au, benh@kernel.crashing.org,
kvm@vger.kernel.org, agraf@suse.com, rkrcmar@redhat.com
Subject: Re: [PATCH 1/4] kvm/ppc/book3s_hv: Change vcore element runnable_threads from linked-list to array
Date: Wed, 29 Jun 2016 14:51:19 +0200 [thread overview]
Message-ID: <f433feff-b8c6-2b99-4357-5146032e7d6d@redhat.com> (raw)
In-Reply-To: <57735226.6010904@gmail.com>
On 29/06/2016 06:44, Suraj Jitindar Singh wrote:
> Thanks for catching that, yeah I see.
>
> I don't think we can trivially move the struct kvmppc_vcore definition into
> kvm_book3s.h as other code in kvm_host.h (i.e. struct kvm_vcpu_arch) requires
> the definition. I was thinking that I could just put runnable_threads inside an #ifdef.
>
> #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE
> struct kvm_vcpu *runnable_threads[MAX_SMT_THREADS];
> #endif
You can rename MAX_SMT_THREADS to BOOK3S_MAX_SMT_THREADS and move it to
kvm_host.h. It seems like assembly code does not use it, so it's
unnecessary to have it in book3s_asm.h.
Paolo
next prev parent reply other threads:[~2016-06-29 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 9:21 [PATCH 1/4] kvm/ppc/book3s_hv: Change vcore element runnable_threads from linked-list to array Suraj Jitindar Singh
2016-06-15 9:21 ` [PATCH 2/4] kvm/ppc/book3s_hv: Implement halt polling in the kvm_hv kernel module Suraj Jitindar Singh
2016-06-15 9:21 ` [PATCH 3/4] kvm/stats: Add provisioning for 64-bit vcpu statistics Suraj Jitindar Singh
2016-06-20 0:08 ` Paul Mackerras
2016-06-20 14:56 ` Paolo Bonzini
2016-06-15 9:21 ` [PATCH 4/4] powerpc/kvm/stats: Implement existing and add new halt polling vcpu stats Suraj Jitindar Singh
2016-06-24 9:59 ` [PATCH 1/4] kvm/ppc/book3s_hv: Change vcore element runnable_threads from linked-list to array Paul Mackerras
2016-06-29 4:44 ` Suraj Jitindar Singh
2016-06-29 12:51 ` Paolo Bonzini [this message]
2016-07-11 6:05 ` Suraj Jitindar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f433feff-b8c6-2b99-4357-5146032e7d6d@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.com \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=rkrcmar@redhat.com \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).