From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jason Wang <wangborong@cdjrlc.com>, benh@kernel.crashing.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Remove a repeated word in a comment
Date: Mon, 15 Nov 2021 09:04:46 +0100 [thread overview]
Message-ID: <f48406ee-6bd8-2340-c79f-96f8882bd757@csgroup.eu> (raw)
In-Reply-To: <20211113044018.130835-1-wangborong@cdjrlc.com>
Le 13/11/2021 à 05:40, Jason Wang a écrit :
> The double word `up' in a comment is repeated, thus one of
> them should be removed.
If you do other changes than this one, say it here as well, see below.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/macintosh/mediabay.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
> index eab7e83c11c4..ec23094263e7 100644
> --- a/drivers/macintosh/mediabay.c
> +++ b/drivers/macintosh/mediabay.c
> @@ -129,7 +129,7 @@ enum {
> /*
> * Functions for polling content of media bay
> */
> -
> +
This change is not part of your description.
> static u8
> ohare_mb_content(struct media_bay_info *bay)
> {
> @@ -331,12 +331,12 @@ static void keylargo_mb_un_reset_ide(struct media_bay_info* bay)
>
> static inline void set_mb_power(struct media_bay_info* bay, int onoff)
> {
> - /* Power up up and assert the bay reset line */
> + /* Power up and assert the bay reset line */
> if (onoff) {
> bay->ops->power(bay, 1);
> bay->state = mb_powering_up;
> pr_debug("mediabay%d: powering up\n", bay->index);
> - } else {
> + } else {
This change is not part of your description.
> /* Make sure everything is powered down & disabled */
> bay->ops->power(bay, 0);
> bay->state = mb_powering_down;
> @@ -577,7 +577,7 @@ static int media_bay_attach(struct macio_dev *mdev,
> macio_release_resources(mdev);
> return -ENOMEM;
> }
> -
> +
This change is not part of your description.
> i = media_bay_count++;
> bay = &media_bays[i];
> bay->mdev = mdev;
> @@ -745,7 +745,7 @@ static int __init media_bay_init(void)
> if (!machine_is(powermac))
> return 0;
>
> - macio_register_driver(&media_bay_driver);
> + macio_register_driver(&media_bay_driver);
This change is not part of your description.
>
> return 0;
> }
>
prev parent reply other threads:[~2021-11-15 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 4:40 [PATCH] mm: Remove a repeated word in a comment Jason Wang
2021-11-15 8:04 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48406ee-6bd8-2340-c79f-96f8882bd757@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox