From: Waiman Long <longman@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-arch@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Ingo Molnar" <mingo@redhat.com>,
"Michal Suchánek" <msuchanek@suse.de>,
"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH v4 0/6] powerpc: queued spinlocks and rwlocks
Date: Fri, 24 Jul 2020 17:11:36 -0400 [thread overview]
Message-ID: <f568c8aa-29b5-dbe9-47b8-ee12ce55cb31@redhat.com> (raw)
In-Reply-To: <20200724131423.1362108-1-npiggin@gmail.com>
On 7/24/20 9:14 AM, Nicholas Piggin wrote:
> Updated with everybody's feedback (thanks all), and more performance
> results.
>
> What I've found is I might have been measuring the worst load point for
> the paravirt case, and by looking at a range of loads it's clear that
> queued spinlocks are overall better even on PV, doubly so when you look
> at the generally much improved worst case latencies.
>
> I have defaulted it to N even though I'm less concerned about the PV
> numbers now, just because I think it needs more stress testing. But
> it's very nicely selectable so should be low risk to include.
>
> All in all this is a very cool technology and great results especially
> on the big systems but even on smaller ones there are nice gains. Thanks
> Waiman and everyone who developed it.
>
> Thanks,
> Nick
>
> Nicholas Piggin (6):
> powerpc/pseries: move some PAPR paravirt functions to their own file
> powerpc: move spinlock implementation to simple_spinlock
> powerpc/64s: implement queued spinlocks and rwlocks
> powerpc/pseries: implement paravirt qspinlocks for SPLPAR
> powerpc/qspinlock: optimised atomic_try_cmpxchg_lock that adds the
> lock hint
> powerpc: implement smp_cond_load_relaxed
>
> arch/powerpc/Kconfig | 15 +
> arch/powerpc/include/asm/Kbuild | 1 +
> arch/powerpc/include/asm/atomic.h | 28 ++
> arch/powerpc/include/asm/barrier.h | 14 +
> arch/powerpc/include/asm/paravirt.h | 87 +++++
> arch/powerpc/include/asm/qspinlock.h | 91 ++++++
> arch/powerpc/include/asm/qspinlock_paravirt.h | 7 +
> arch/powerpc/include/asm/simple_spinlock.h | 288 ++++++++++++++++
> .../include/asm/simple_spinlock_types.h | 21 ++
> arch/powerpc/include/asm/spinlock.h | 308 +-----------------
> arch/powerpc/include/asm/spinlock_types.h | 17 +-
> arch/powerpc/lib/Makefile | 3 +
> arch/powerpc/lib/locks.c | 12 +-
> arch/powerpc/platforms/pseries/Kconfig | 9 +-
> arch/powerpc/platforms/pseries/setup.c | 4 +-
> include/asm-generic/qspinlock.h | 4 +
> 16 files changed, 588 insertions(+), 321 deletions(-)
> create mode 100644 arch/powerpc/include/asm/paravirt.h
> create mode 100644 arch/powerpc/include/asm/qspinlock.h
> create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt.h
> create mode 100644 arch/powerpc/include/asm/simple_spinlock.h
> create mode 100644 arch/powerpc/include/asm/simple_spinlock_types.h
>
That patch series looks good to me. Thanks for working on this.
For the series,
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2020-07-24 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 13:14 [PATCH v4 0/6] powerpc: queued spinlocks and rwlocks Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 1/6] powerpc/pseries: move some PAPR paravirt functions to their own file Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 2/6] powerpc: move spinlock implementation to simple_spinlock Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 3/6] powerpc/64s: implement queued spinlocks and rwlocks Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 4/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 5/6] powerpc/qspinlock: optimised atomic_try_cmpxchg_lock that adds the lock hint Nicholas Piggin
2020-07-24 13:14 ` [PATCH v4 6/6] powerpc: implement smp_cond_load_relaxed Nicholas Piggin
2020-07-24 21:10 ` Waiman Long
2020-07-24 21:11 ` Waiman Long [this message]
2020-07-27 7:26 ` [PATCH v4 0/6] powerpc: queued spinlocks and rwlocks Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f568c8aa-29b5-dbe9-47b8-ee12ce55cb31@redhat.com \
--to=longman@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).