From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD5AC433E2 for ; Tue, 8 Sep 2020 13:14:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE0D923BCF for ; Tue, 8 Sep 2020 13:14:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE0D923BCF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bm5Fp5gd3zDqSn for ; Tue, 8 Sep 2020 23:14:06 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bm5C901TWzDqRc for ; Tue, 8 Sep 2020 23:11:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id 4Bm5C85mcCz8syr for ; Tue, 8 Sep 2020 23:11:48 +1000 (AEST) Received: by ozlabs.org (Postfix) id 4Bm5C85MzVz9sTX; Tue, 8 Sep 2020 23:11:48 +1000 (AEST) Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bm5C80wqFz9sSn for ; Tue, 8 Sep 2020 23:11:45 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Bm5C10L9lz9tytT; Tue, 8 Sep 2020 15:11:41 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 0yrBPq4xOkCS; Tue, 8 Sep 2020 15:11:40 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Bm5C066pzz9tytR; Tue, 8 Sep 2020 15:11:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 57F758B7C5; Tue, 8 Sep 2020 15:11:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id urzp2p3UnTc6; Tue, 8 Sep 2020 15:11:42 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0F2828B7BE; Tue, 8 Sep 2020 15:11:42 +0200 (CEST) Subject: Re: [PATCH] powerpc/64: Make VDSO32 track COMPAT on 64-bit To: Michael Ellerman , linuxppc-dev@ozlabs.org References: <20200908125850.407939-1-mpe@ellerman.id.au> From: Christophe Leroy Message-ID: Date: Tue, 8 Sep 2020 15:11:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908125850.407939-1-mpe@ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: msuchanek@suse.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 08/09/2020 à 14:58, Michael Ellerman a écrit : > When we added the VDSO32 kconfig symbol, which controls building of > the 32-bit VDSO, we made it depend on CPU_BIG_ENDIAN (for 64-bit). > > That was because back then COMPAT was always enabled for 64-bit, so > depending on it would have left the 32-bit VDSO always enabled, which > we didn't want. > > But since then we have made COMPAT selectable, and off by default for > ppc64le, so VDSO32 should really depend on that. > > For most people this makes no difference, none of the defconfigs > change, it's only if someone is building ppc64le with COMPAT=y, they > will now also get VDSO32. If they've enabled COMPAT in order to run > 32-bit binaries they presumably also want the 32-bit VDSO. > > Signed-off-by: Michael Ellerman Reviewed-by: Christophe Leroy Michael, please note that christophe.leroy@c-s.fr is a deprecated address that will one day not work anymore. Please use the new one whenever possible. Christophe > --- > arch/powerpc/platforms/Kconfig.cputype | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype > index 87737ec86d39..a80ad0ef436e 100644 > --- a/arch/powerpc/platforms/Kconfig.cputype > +++ b/arch/powerpc/platforms/Kconfig.cputype > @@ -490,13 +490,12 @@ endmenu > > config VDSO32 > def_bool y > - depends on PPC32 || CPU_BIG_ENDIAN > + depends on PPC32 || COMPAT > help > This symbol controls whether we build the 32-bit VDSO. We obviously > want to do that if we're building a 32-bit kernel. If we're building > - a 64-bit kernel then we only want a 32-bit VDSO if we're building for > - big endian. That is because the only little endian configuration we > - support is ppc64le which is 64-bit only. > + a 64-bit kernel then we only want a 32-bit VDSO if we're also enabling > + COMPAT. > > choice > prompt "Endianness selection" >