From: Abhishek <huntbag@linux.vnet.ibm.com>
To: Daniel Axtens <dja@axtens.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-pm@vger.kernel.org
Cc: daniel.lezcano@linaro.org, rjw@rjwysocki.net, ego@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/2] cpuidle : auto-promotion for cpuidle states
Date: Tue, 9 Apr 2019 15:06:47 +0530 [thread overview]
Message-ID: <f8a0e5ad-44d1-9a12-1995-57f3671a5889@linux.vnet.ibm.com> (raw)
In-Reply-To: <87lg0kwp3t.fsf@dja-thinkpad.axtens.net>
Hi Daniel,
On 04/08/2019 07:55 PM, Daniel Axtens wrote:
> Hi,
>
> Sorry, just realised another thing I wanted to ask:
>
>> @@ -442,6 +442,26 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
>> }
>> }
>>
>>
>> +#ifdef CPUIDLE_FLAG_AUTO_PROMOTION
> Why is this based on CPUIDLE_FLAG_ rather than CONFIG_CPU_IDLE_? Won't
> this always be true, given that the flag is defined regardless of the
> config option in the header?
Yeah, You are right. This should have been CONFIG_CPU_IDLE_AUTO_PROMOTION.
--Abhishek
next prev parent reply other threads:[~2019-04-09 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 9:16 [PATCH v2 0/2] Auto-promotion logic for cpuidle states Abhishek Goel
2019-04-05 9:16 ` [PATCH v2 1/2] cpuidle : auto-promotion " Abhishek Goel
2019-04-08 14:12 ` Daniel Axtens
2019-04-09 9:28 ` Abhishek
2019-04-09 9:30 ` Rafael J. Wysocki
2019-04-09 9:42 ` Abhishek
2019-04-08 14:25 ` Daniel Axtens
2019-04-09 9:36 ` Abhishek [this message]
2019-04-09 10:01 ` Rafael J. Wysocki
2019-04-14 20:04 ` Abhishek
2019-04-05 9:16 ` [PATCH v2 2/2] cpuidle : Add auto-promotion flag to cpuidle flags Abhishek Goel
2019-04-08 14:22 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a0e5ad-44d1-9a12-1995-57f3671a5889@linux.vnet.ibm.com \
--to=huntbag@linux.vnet.ibm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dja@axtens.net \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).