From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72CBDD6409D for ; Wed, 17 Dec 2025 09:26:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dWT2n0PDhz2ypm; Wed, 17 Dec 2025 20:26:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765963616; cv=none; b=SCvnEzglL6EYFNNXuSqTsF4OpU2aXsFhx2zdPY4eazNqk6mXqTxMFN5LhMOef7wxP2ilSOWSe6pZzPUfUl1iOcbUf76aZQRIkO32GJtUt7IDwmKulhLmcYaUp25NGD4YBl5K2ao66gyw1Oqb3jPlaFtOGhzzHyEMMPJSu1mQLAUs+2L6i5zxn6SLRqMGUsfCu+821jhnBlnT/r/ZE9L6grw0/WK7NoTlmaASTf8EivJ9feIaDjHTAcXkelVndtXeIHE1GPTWav/sj7sT41+nBCPQQALvx7iwGTRsbiLIGlSqCjh9TUdBeORo7oq8sXopTcHN9BhYGSZMQ4lGJASuqg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1765963616; c=relaxed/relaxed; bh=ZwihpIkffId1o87zl/G9jlo/Pzu9AzPacFtF7GHeHUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h7giNNY6FSMt7/hQODHO1nBFS6Lalug1Pj6uECNtABikPQJCU+dl2JmTlB290VK7LbhupxEZ+Pec5rl57UHD+2lK26SkSUFv+0qpZc0wquSIVMZ6rHwcn/rQ32EDTLRkS9VpZhNir4t5cSTQTxNsEgDkffn2CyMbFwiJYB/4dMmMW5HPzKYzjVpLP9O89ncahSRhXTIvHGPIFgrh/X1SrgHLEFVFughvtKr0H+0e9/sv5Vec6dTGsvhyf2ucr+5IrXv9Xs1Eh0SBJZc9wZVE/yqydbOkxf1Wr17PxZnTWmHpvXusj0S6GdxTGRctu7eAQ2cOQpsmDL8IekBsQRp6jw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=kevin.brodsky@arm.com; receiver=lists.ozlabs.org) smtp.mailfrom=arm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=kevin.brodsky@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4dWT2l6bhHz2yjw for ; Wed, 17 Dec 2025 20:26:54 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B975914BF; Wed, 17 Dec 2025 01:26:14 -0800 (PST) Received: from [10.57.47.3] (unknown [10.57.47.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA6A93F762; Wed, 17 Dec 2025 01:26:14 -0800 (PST) Message-ID: Date: Wed, 17 Dec 2025 10:26:12 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 14/14] mm: Add basic tests for lazy_mmu To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Anshuman Khandual , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , "David S. Miller" , David Woodhouse , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , "Ritesh Harjani (IBM)" , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Venkat Rao Bagalkote , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org References: <20251215150323.2218608-1-kevin.brodsky@arm.com> <20251215150323.2218608-15-kevin.brodsky@arm.com> <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> From: Kevin Brodsky Content-Language: en-GB In-Reply-To: <20251216201403.4647a4f9861d3122ee9e90d7@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/12/2025 05:14, Andrew Morton wrote: > On Mon, 15 Dec 2025 15:03:23 +0000 Kevin Brodsky wrote: > >> Add basic KUnit tests for the generic aspects of the lazy MMU mode: >> ensure that it appears active when it should, depending on how >> enable/disable and pause/resume pairs are nested. > I needed this for powerpc allmodconfig; > > --- a/arch/powerpc/mm/book3s64/hash_tlb.c~mm-add-basic-tests-for-lazy_mmu-fix > +++ a/arch/powerpc/mm/book3s64/hash_tlb.c > @@ -30,6 +30,7 @@ > #include > > DEFINE_PER_CPU(struct ppc64_tlb_batch, ppc64_tlb_batch); > +EXPORT_SYMBOL_GPL(ppc64_tlb_batch); > > /* > * A linux PTE was changed and the corresponding hash table entry > @@ -154,6 +155,7 @@ void __flush_tlb_pending(struct ppc64_tl > flush_hash_range(i, local); > batch->index = 0; > } > +EXPORT_SYMBOL_GPL(__flush_tlb_pending); > > void hash__tlb_flush(struct mmu_gather *tlb) > { > _ Oh indeed I hadn't considered that arch_{enter,leave}_lazy_mmu_mode() refer to those symbols on powerpc... Maybe a bit overkill to export those just for a test module, but I'm not sure there's a good alternative. Forcing LAZY_MMU_MODE_KUNIT_TEST=y is ugly as it would also force KUNIT=y. Alternatively we could depend on !PPC, not pretty either. - Kevin