From: kajoljain <kjain@linux.ibm.com>
To: Ian Rogers <irogers@google.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Kim Phillips <kim.phillips@amd.com>,
Florian Fischer <florian.fischer@muhq.space>,
Ravi Bangoria <ravi.bangoria@amd.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Kang Minchul <tegongkang@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Sandipan Das <sandipan.das@amd.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Perry Taylor <perry.taylor@intel.com>,
Caleb Biggers <caleb.biggers@intel.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v3 01/11] perf jevents metric: Correct Function equality
Date: Wed, 25 Jan 2023 10:25:17 +0530 [thread overview]
Message-ID: <f9d26106-95d2-69ae-b7ed-1b47449dacd1@linux.ibm.com> (raw)
In-Reply-To: <20230124063320.668917-2-irogers@google.com>
On 1/24/23 12:03, Ian Rogers wrote:
> rhs may not be defined, say for source_count, so add a guard.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/pmu-events/metric.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/pmu-events/metric.py b/tools/perf/pmu-events/metric.py
> index 4797ed4fd817..2f2fd220e843 100644
> --- a/tools/perf/pmu-events/metric.py
> +++ b/tools/perf/pmu-events/metric.py
> @@ -261,8 +261,10 @@ class Function(Expression):
>
> def Equals(self, other: Expression) -> bool:
> if isinstance(other, Function):
> - return self.fn == other.fn and self.lhs.Equals(
> - other.lhs) and self.rhs.Equals(other.rhs)
> + result = self.fn == other.fn and self.lhs.Equals(other.lhs)
> + if self.rhs:
> + result = result and self.rhs.Equals(other.rhs)
> + return result
> return False
>
>
Patch looks good to me.
Reviewed-by: Kajol Jain<kjain@linux.ibm.com>
Thanks,
Kajol Jain
next prev parent reply other threads:[~2023-01-25 4:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 6:33 [PATCH v3 00/11] jevents/pmu-events improvements Ian Rogers
2023-01-24 6:33 ` [PATCH v3 01/11] perf jevents metric: Correct Function equality Ian Rogers
2023-01-25 4:55 ` kajoljain [this message]
2023-01-24 6:33 ` [PATCH v3 02/11] perf jevents metric: Add ability to rewrite metrics in terms of others Ian Rogers
2023-01-24 6:33 ` [PATCH v3 03/11] perf jevents: Rewrite metrics in the same file with each other Ian Rogers
2023-01-24 6:33 ` [PATCH v3 04/11] perf pmu-events: Add separate metric from pmu_event Ian Rogers
2023-01-24 16:20 ` John Garry
2023-01-24 6:33 ` [PATCH v3 05/11] perf pmu-events: Separate the metrics from events for no jevents Ian Rogers
2023-01-24 16:24 ` John Garry
2023-01-24 6:33 ` [PATCH v3 06/11] perf pmu-events: Remove now unused event and metric variables Ian Rogers
2023-01-25 16:55 ` John Garry
2023-01-24 6:33 ` [PATCH v3 07/11] perf stat: Remove evsel metric_name/expr Ian Rogers
2023-01-24 6:33 ` [PATCH v3 08/11] perf jevents: Combine table prefix and suffix writing Ian Rogers
2023-01-24 6:33 ` [PATCH v3 09/11] perf pmu-events: Introduce pmu_metrics_table Ian Rogers
2023-01-24 6:33 ` [PATCH v3 10/11] perf jevents: Generate metrics and events as separate tables Ian Rogers
2023-01-24 6:33 ` [PATCH v3 11/11] perf jevents: Add model list option Ian Rogers
2023-01-25 17:05 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d26106-95d2-69ae-b7ed-1b47449dacd1@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=caleb.biggers@intel.com \
--cc=eranian@google.com \
--cc=florian.fischer@muhq.space \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=perry.taylor@intel.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=robh@kernel.org \
--cc=sandipan.das@amd.com \
--cc=tegongkang@gmail.com \
--cc=will@kernel.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).