From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.230]) by ozlabs.org (Postfix) with ESMTP id 68555DDE30 for ; Thu, 7 Jun 2007 05:55:27 +1000 (EST) Received: by nz-out-0506.google.com with SMTP id v1so266854nzb for ; Wed, 06 Jun 2007 12:55:26 -0700 (PDT) Message-ID: Date: Wed, 6 Jun 2007 13:55:25 -0600 From: "Grant Likely" Sender: glikely@secretlab.ca To: "Stephen Neuendorffer" Subject: Re: [PATCH] Simple driver for Xilinx SPI controler. In-Reply-To: <20070606190640.B7028900053@mail104-cpk.bigfish.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <20070606190640.B7028900053@mail104-cpk.bigfish.com> Cc: spi-devel-general@lists.sourceforge.net, Andrei Konovalov , Wolfgang Reissnegger , linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/6/07, Stephen Neuendorffer wrote: > > Why still have XILINX_EDK? I thought you meant replace > > XILINX_EDK with XILINX_DRIVERS. > > Yes, that's what I was suggesting. > But I think that Andrei still wants to use XILINX_EDK to pull in the > stuff in drivers/xilinx_common. > > # The Xilinx OS common code > obj-$(CONFIG_XILINX_EDK) += xbasic_types.o xpacket_fifo_l_v2_00_a.o \ > xpacket_fifo_v2_00_a.o xversion.o \ > xdma_channel.o xdma_channel_sg.o > > Which you wouldn't want if you were able to build a kernel completely > from 'non-edk' drivers. Fair enough, but that's only an issue for vendor trees. None of this code will be going into mainline. Any of it that does get into good shape should probably go under drivers/misc, and have the drivers select only the pieces that are needed (with finer-grain CONFIG_ items). A blanked CONFIG_XILINX_EDK for random stuff is not a good idea. Cheers, g. > > Steve > > > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195